Bug#1115555: hintview FTCBFS: builds for the build architecture
Hi Hilmar,
On Fri, Sep 19, 2025 at 11:37:01PM +0200, Hilmar Preuße wrote:
> After applying the patch, the include statements to the gcc command is
> missing, hence the gtk.h is not found and the build fails. Please refine
> your patch, thanks!
My fault. I attempted unifying the two PKGCONFIG assignments but ended
up putting them into a branch. Moved around. This didn't fail in the
cross build and I missed a native test build after my last iteration of
changes.
Helmut
diff -Nru hintview-2.1.0/debian/changelog hintview-2.1.0/debian/changelog
--- hintview-2.1.0/debian/changelog 2024-12-09 21:53:34.000000000 +0100
+++ hintview-2.1.0/debian/changelog 2025-09-11 08:14:17.000000000 +0200
@@ -1,3 +1,12 @@
+hintview (2.1.0-1.1) UNRELEASED; urgency=medium
+
+ * Non-maintainer upload.
+ * Fix FTCBFS: (Closes: #-1)
+ + Let dh_auto_build pass cross tools to make.
+ + cross.patch: Use standard tool variables.
+
+ -- Helmut Grohne <helmut@subdivi.de> Thu, 11 Sep 2025 08:14:17 +0200
+
hintview (2.1.0-1) unstable; urgency=medium
* New upstream version, obsoletes patches.
diff -Nru hintview-2.1.0/debian/patches/cross.patch hintview-2.1.0/debian/patches/cross.patch
--- hintview-2.1.0/debian/patches/cross.patch 1970-01-01 01:00:00.000000000 +0100
+++ hintview-2.1.0/debian/patches/cross.patch 2025-09-11 08:14:17.000000000 +0200
@@ -0,0 +1,27 @@
+--- hintview-2.1.0.orig/Linux/Makefile
++++ hintview-2.1.0/Linux/Makefile
+@@ -4,18 +4,17 @@
+ WITH_GTK=0
+ endif
+
+-ifeq ($(WITH_GTK),0)
++PKG_CONFIG ?= pkg-config
+
++ifeq ($(WITH_GTK),0)
+ GTK_CFLAGS = -DWITH_GTK=0
+ GTL_LIBS =
+ else ifeq ($(WITH_GTK),2)
+-PKGCONFIG = $(shell which pkg-config)
+-GTK_CFLAGS = $(shell $(PKGCONFIG) --cflags gtk+-2.0) -DWITH_GTK=2
+-GTK_LIBS = $(shell $(PKGCONFIG) --libs gtk+-2.0)
++GTK_CFLAGS = $(shell $(PKG_CONFIG) --cflags gtk+-2.0) -DWITH_GTK=2
++GTK_LIBS = $(shell $(PKG_CONFIG) --libs gtk+-2.0)
+ else ifeq ($(WITH_GTK),3)
+-PKGCONFIG = $(shell which pkg-config)
+-GTK_CFLAGS = $(shell $(PKGCONFIG) --cflags gtk+-3.0) -DWITH_GTK=3
+-GTK_LIBS = $(shell $(PKGCONFIG) --libs gtk+-3.0)
++GTK_CFLAGS = $(shell $(PKG_CONFIG) --cflags gtk+-3.0) -DWITH_GTK=3
++GTK_LIBS = $(shell $(PKG_CONFIG) --libs gtk+-3.0)
+ else
+ $(error "Valid values for WITH_GTK are 0, 2 or 3")
+ endif
diff -Nru hintview-2.1.0/debian/patches/series hintview-2.1.0/debian/patches/series
--- hintview-2.1.0/debian/patches/series 2024-12-09 21:40:57.000000000 +0100
+++ hintview-2.1.0/debian/patches/series 2025-09-11 08:14:17.000000000 +0200
@@ -1,2 +1,3 @@
#add_GL.patch
#manpage_section.patch
+cross.patch
diff -Nru hintview-2.1.0/debian/rules hintview-2.1.0/debian/rules
--- hintview-2.1.0/debian/rules 2023-10-31 19:57:44.000000000 +0100
+++ hintview-2.1.0/debian/rules 2025-09-11 08:14:17.000000000 +0200
@@ -18,7 +18,7 @@
dh $@
override_dh_auto_build:
- cd Linux; WITH_GTK=3 make
+ WITH_GTK=3 dh_auto_build --sourcedirectory=Linux
#override_dh_auto_configure:
# dh_auto_configure -- \
Reply to: