[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Fwd: Bug#1077439: latex-cjk-japanese-wadalab: FTBFS: wftodm.c:57:1: error: return type defaults to ‘int’ [-Wimplicit-int]



Hi Hilmar,

When compiling wftodm.c from the latex-cjk-japanese-wadalab package, I get a bunch of warnings with GCC 13 (see also below Lucas' output).
To me, these seems just fairly benign warnings based on deprecated C89 conventions.

With this bug report, I've been thinking: should we continue to put time and effort in a venerable but older package like CJK?
Or do we keep this package as legacy, and forcefully ignore some of the warnings of the C compiler?

Let me know what you think.

Cheers,

-- 
Danai

---------- Forwarded message ---------
From: Danai SAE-HAN (韓達耐) <danai.saehan@gmail.com>
Date: Mon, 29 Jul 2024 at 14:16
Subject: Re: Bug#1077439: latex-cjk-japanese-wadalab: FTBFS: wftodm.c:57:1: error: return type defaults to ‘int’ [-Wimplicit-int]
To: Lucas Nussbaum <lucas@debian.org>, <1077439@bugs.debian.org>
Cc: <submit@bugs.debian.org>


Thanks, Lucas!  I'll check it out.


On Mon, 29 Jul 2024, 13:54 Lucas Nussbaum, <lucas@debian.org> wrote:
Source: latex-cjk-japanese-wadalab
Version: 0.20050817-18
Severity: serious
Justification: FTBFS
Tags: trixie sid ftbfs
User: lucas@debian.org
Usertags: ftbfs-20240728 ftbfs-trixie

Hi,

During a rebuild of all packages in sid, your package failed to build
on amd64.


Relevant part (hopefully):
> cc -Wall -g -O2 -o build/wftodm wftodm.c
> wftodm.c:57:1: error: return type defaults to ‘int’ [-Wimplicit-int]
>    57 | compute_fc(ku, ten, f, c)
>       | ^~~~~~~~~~
> wftodm.c: In function ‘compute_fc’:
> wftodm.c:69:9: error: ‘return’ with no value, in function returning non-void [-Wreturn-mismatch]
>    69 |         return;
>       |         ^~~~~~
> wftodm.c:57:1: note: declared here
>    57 | compute_fc(ku, ten, f, c)
>       | ^~~~~~~~~~
> wftodm.c:73:9: error: ‘return’ with no value, in function returning non-void [-Wreturn-mismatch]
>    73 |         return;
>       |         ^~~~~~
> wftodm.c:57:1: note: declared here
>    57 | compute_fc(ku, ten, f, c)
>       | ^~~~~~~~~~
> wftodm.c: At top level:
> wftodm.c:99:1: error: return type defaults to ‘int’ [-Wimplicit-int]
>    99 | readfiles(filename)
>       | ^~~~~~~~~
> wftodm.c: In function ‘readfiles’:
> wftodm.c:104:7: warning: unused variable ‘kcode_low’ [-Wunused-variable]
>   104 |   int kcode_low,i,len,kcode,c1;
>       |       ^~~~~~~~~
> wftodm.c: At top level:
> wftodm.c:128:1: error: return type defaults to ‘int’ [-Wimplicit-int]
>   128 | main(ac,ag)
>       | ^~~~
> wftodm.c: In function ‘main’:
> wftodm.c:128:1: error: type of ‘ac’ defaults to ‘int’ [-Wimplicit-int]
> wftodm.c:158:7: error: implicit declaration of function ‘output_pfa’ [-Wimplicit-function-declaration]
>   158 |       output_pfa(i);
>       |       ^~~~~~~~~~
> wftodm.c:159:7: error: implicit declaration of function ‘output_afm’ [-Wimplicit-function-declaration]
>   159 |       output_afm(i);
>       |       ^~~~~~~~~~
> wftodm.c: At top level:
> wftodm.c:164:1: error: return type defaults to ‘int’ [-Wimplicit-int]
>   164 | output_afm(file)
>       | ^~~~~~~~~~
> wftodm.c: In function ‘output_afm’:
> wftodm.c:164:1: error: type of ‘file’ defaults to ‘int’ [-Wimplicit-int]
> wftodm.c: At top level:
> wftodm.c:196:1: error: return type defaults to ‘int’ [-Wimplicit-int]
>   196 | output_header(file)
>       | ^~~~~~~~~~~~~
> wftodm.c: In function ‘output_header’:
> wftodm.c:196:1: error: type of ‘file’ defaults to ‘int’ [-Wimplicit-int]
> wftodm.c: At top level:
> wftodm.c:230:1: error: return type defaults to ‘int’ [-Wimplicit-int]
>   230 | output_pfa(file)
>       | ^~~~~~~~~~
> wftodm.c: In function ‘output_pfa’:
> wftodm.c:230:1: error: type of ‘file’ defaults to ‘int’ [-Wimplicit-int]
> wftodm.c:243:3: error: implicit declaration of function ‘init_crypt’ [-Wimplicit-function-declaration]
>   243 |   init_crypt();
>       |   ^~~~~~~~~~
> wftodm.c:244:3: error: implicit declaration of function ‘e_putchar’; did you mean ‘putchar’? [-Wimplicit-function-declaration]
>   244 |   e_putchar(0);
>       |   ^~~~~~~~~
>       |   putchar
> wftodm.c:248:3: error: implicit declaration of function ‘e_printf’; did you mean ‘dprintf’? [-Wimplicit-function-declaration]
>   248 |   e_printf("dup /Private 17 dict dup begin\n");
>       |   ^~~~~~~~
>       |   dprintf
> wftodm.c:232:15: warning: unused variable ‘charlen’ [-Wunused-variable]
>   232 |   int i,j,len,charlen;
>       |               ^~~~~~~
> wftodm.c:232:11: warning: unused variable ‘len’ [-Wunused-variable]
>   232 |   int i,j,len,charlen;
>       |           ^~~
> wftodm.c: At top level:
> wftodm.c:301:1: error: return type defaults to ‘int’ [-Wimplicit-int]
>   301 | e_printf(form,i0,i1,i2,i3,i4,i5,i6,i7,i8,i9)
>       | ^~~~~~~~
> wftodm.c: In function ‘e_printf’:
> wftodm.c:301:1: error: type of ‘i1’ defaults to ‘int’ [-Wimplicit-int]
> wftodm.c:301:1: error: type of ‘i2’ defaults to ‘int’ [-Wimplicit-int]
> wftodm.c:301:1: error: type of ‘i3’ defaults to ‘int’ [-Wimplicit-int]
> wftodm.c:301:1: error: type of ‘i4’ defaults to ‘int’ [-Wimplicit-int]
> wftodm.c:301:1: error: type of ‘i5’ defaults to ‘int’ [-Wimplicit-int]
> wftodm.c:301:1: error: type of ‘i6’ defaults to ‘int’ [-Wimplicit-int]
> wftodm.c:301:1: error: type of ‘i7’ defaults to ‘int’ [-Wimplicit-int]
> wftodm.c:301:1: error: type of ‘i8’ defaults to ‘int’ [-Wimplicit-int]
> wftodm.c:301:1: error: type of ‘i9’ defaults to ‘int’ [-Wimplicit-int]
> wftodm.c:307:11: warning: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Wpointer-sign]
>   307 |   sprintf(buf,form,i0,i1,i2,i3,i4,i5,i6,i7,i8,i9);
>       |           ^~~
>       |           |
>       |           unsigned char *
> In file included from wftodm.c:1:
> /usr/include/stdio.h:365:38: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’
>   365 | extern int sprintf (char *__restrict __s,
>       |                     ~~~~~~~~~~~~~~~~~^~~
> wftodm.c:308:14: warning: pointer targets in passing argument 1 of ‘strlen’ differ in signedness [-Wpointer-sign]
>   308 |   len=strlen(buf);
>       |              ^~~
>       |              |
>       |              unsigned char *
> In file included from wftodm.c:2:
> /usr/include/string.h:407:35: note: expected ‘const char *’ but argument is of type ‘unsigned char *’
>   407 | extern size_t strlen (const char *__s)
>       |                       ~~~~~~~~~~~~^~~
> wftodm.c: At top level:
> wftodm.c:312:1: error: return type defaults to ‘int’ [-Wimplicit-int]
>   312 | e_putchar(plain)
>       | ^~~~~~~~~
> wftodm.c: In function ‘e_putchar’:
> wftodm.c:315:22: error: implicit declaration of function ‘encrypt_char’ [-Wimplicit-function-declaration]
>   315 |   fprintf(ofp,"%02X",encrypt_char(plain));
>       |                      ^~~~~~~~~~~~
> wftodm.c: At top level:
> wftodm.c:321:1: error: return type defaults to ‘int’ [-Wimplicit-int]
>   321 | init_crypt()
>       | ^~~~~~~~~~
> wftodm.c:326:1: error: return type defaults to ‘int’ [-Wimplicit-int]
>   326 | encrypt_char(plain)
>       | ^~~~~~~~~~~~
> wftodm.c: In function ‘readfiles’:
> wftodm.c:126:1: warning: control reaches end of non-void function [-Wreturn-type]
>   126 | }
>       | ^
> wftodm.c: In function ‘output_afm’:
> wftodm.c:193:1: warning: control reaches end of non-void function [-Wreturn-type]
>   193 | }
>       | ^
> wftodm.c: In function ‘output_header’:
> wftodm.c:229:1: warning: control reaches end of non-void function [-Wreturn-type]
>   229 | }
>       | ^
> wftodm.c: In function ‘output_pfa’:
> wftodm.c:299:1: warning: control reaches end of non-void function [-Wreturn-type]
>   299 | }
>       | ^
> wftodm.c: In function ‘e_printf’:
> wftodm.c:311:1: warning: control reaches end of non-void function [-Wreturn-type]
>   311 | }
>       | ^
> wftodm.c: In function ‘e_putchar’:
> wftodm.c:318:1: warning: control reaches end of non-void function [-Wreturn-type]
>   318 | }
>       | ^
> wftodm.c: In function ‘init_crypt’:
> wftodm.c:325:1: warning: control reaches end of non-void function [-Wreturn-type]
>   325 | }
>       | ^
> make: *** [debian/rules:56: unpack-stamp] Error 1


The full build log is available from:
http://qa-logs.debian.net/2024/07/28/latex-cjk-japanese-wadalab_0.20050817-18_unstable.log

All bugs filed during this archive rebuild are listed at:
https://bugs.debian.org/cgi-bin/pkgreport.cgi?tag=ftbfs-20240728;users=lucas@debian.org
or:
https://udd.debian.org/bugs/?release=na&merged=ign&fnewerval=7&flastmodval=7&fusertag=only&fusertagtag=ftbfs-20240728&fusertaguser=lucas@debian.org&allbugs=1&cseverity=1&ctags=1&caffected=1#results

A list of current common problems and possible solutions is available at
http://wiki.debian.org/qa.debian.org/FTBFS . You're welcome to contribute!

If you reassign this bug to another package, please mark it as 'affects'-ing
this package. See https://www.debian.org/Bugs/server-control#affects

If you fail to reproduce this, please provide a build log and diff it with mine
so that we can identify if something relevant changed in the meantime.


Reply to: