Bug#1061151: asymptote: should run tests at build time
Am 20.01.2024 um 10:22 schrieb Preuße, Hilmar:
> On 19.01.2024 18:04, Sven Joachim wrote:
>> On 2024-01-19 17:11 +0100, Sven Joachim wrote:
>
> Hi Sven,
>
>>> Your package has a test suite that probably should be run at build time,
>>> but it is not. I looked at the git repository and found that it has
>>> been disabled since at least 2015:
>>>
>>> ,----
>>> | $ git show f69991bf3
>>> | commit f69991bf3cf85c0560ac93a2b24d96ce67c061d9
>>> | Author: Norbert Preining <norbert@preining.info>
>>> | Date: Tue Jun 23 08:41:59 2015 +0900
>>> |
>>> | do not do testing
>>> |
>>> | diff --git a/debian/rules b/debian/rules
>>> | index 6d9d7387..2d52d8f6 100755
>>> | --- a/debian/rules
>>> | +++ b/debian/rules
>>> | @@ -22,6 +22,9 @@ override_dh_auto_install:
>>> | make install-asy DESTDIR=$(CURDIR)/debian/tmp
>>> | dh_installtex -pasymptote
>>> |
>>> | +override_dh_auto_test:
>>> | + : do nothing here, otherwise make tries to compile prc/test.cc
>>> | +
>>> | override_dh_clean:
>>> | dh_clean
>>> | rm --force doc/latexusage.pdf doc/latexusage.dvi doc/TeXShopAndAsymptote.dvi doc/CAD.dvi
>>> `----
>>>
>>> This leaves me rather puzzled: why exactly would it bad if make tries to
>>> compile prc/test.cc?
>> Out of curiosity, I removed the dh_auto_test override and built the
>> package with "sbuild --no-arch-all". This ran the test suite where
>> various files were compiled, but not prc/test.cc. The build was
>> successful.
>>
>
> As you noticed I did not enter that entry and the person who did that
> does not actively work for Debian any more. Maybe at the time of the
> commit the file prc/test.cc was still compiled and linked and that was
> bad somehow.
Perhaps. I am not too interested in doing archeology, what matters is
that the comment clearly is wrong now.
> Anyway I'd like to leave it as it is: there are some slow
> architectures, hence I'd not run the test suite on all arches.
The test suite takes only about 1% of the overall build time (in a fresh
sbuild chroot where all the build dependencies have to be installed
first, which takes quite long).
Cheers,
Sven
Reply to: