Bug#940191: texlive-binaries: xdvi does not display enclosed eps graphics due to ghostscript dropped execute command (patch)

[Chris Liddell <chris.liddell@artifex.com>]

On 18/09/2019 09:15, Norbert Preining wrote:
> Hi Camm, hi Chris,
> 
> On Fri, 13 Sep 2019, Camm Maguire wrote:
>> buster unable to render enclosed eps graphics.  xdvik-ja has
>> implemented execute natively in version -3 with the patch below,
> 
> Upstream xdvi-k is using the following patch that is already in our
> repository for the next upload:
> 
> diff --git a/texk/xdvik/psgs.c b/texk/xdvik/psgs.c
> index 98df53717..bb70ef7db 100644
> --- a/texk/xdvik/psgs.c
> +++ b/texk/xdvik/psgs.c
> @@ -561,7 +561,8 @@ initGS(void)
>         ">> setuserparams .locksafe "
>         "} stopped pop\n";
>      static const char str1[] =
> -       "/xdvi$run {$error /newerror false put {currentfile cvx execute} stopped pop} "
> +        "/xdvi$run "
> +        "{$error /newerror false put currentfile cvx stopped {handleerror} if} "
>         "def "
>         "/xdvi$ack (\347\310\376) def "
>         "/xdvi$dslen countdictstack def "
> 
> That should work as expected. Have you any objections to the above
> improvement?

That seems absolutely ideal to me. In fact, I would say it is probably
how it should have been done originally.

That's not apportioning any blame: I *know* various past and
(unfortunately) current Ghostscript developers have given out code
snippets and recommendations that rely (needlessly) on Ghostscript
custom/internal operators. I'm sorry if that's what happened, and sorry
for the upheaval, regardless.


I know this is all something of a pain, but *hopefully* everyone
understands and appreciates the ultimate end is a Postscript environment
that is less vulnerable to malicious attacks.

Cheers,

Chris