[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#890734: texlive-metapost: mpost does not honour SOURCE_DATE_EPOCH



Control: tags 890734 + patch

Am 04.08.2019 um 00:25 teilte Gero Treuner mit:

Hi Gero,

> As earlier Metapost user I have it installed and just saw the call for
> help while updating my system.
> 
Many thanks!

> According to the discussion and supposed plan and SOURCE_DATE_EPOCH
> page I have a patch ready (see attachment), which follows the original
> coding style. A test looks ok: %%CreationDate: honors the environment
> variable, format is the same as before.
> 
> Note: Patch was made against the Buster version
> (texlive-bin-2018.20181218.49446).
> 
That's fine. In Debian unstable we had just an offset of 30 lines.
I applied the patch, compiled the binary and can confirm that is solves
the problem.

> I'm not a Debian developer/maintainer, so please check and adopt it 
> according all your procedures (including QA).
> 
Our coding styles are described here [1]. The only adaption I found was:

Variable declarations
.....................
The declaration of global variables follows analogous rules: they are
either declared 'static' if used in only one file or declared 'extern'
in exactly one header and instantiated in exactly one file.

--> As far as I can see your new variable is only one time used in the
mpost code, hence I declared it to be static. Do you agree here?

Regards,
  Hilmar

[1] https://github.com/debian-tex/texlive-bin/blob/master/README.6coding
-- 
sigfault
#206401 http://counter.li.org

Attachment: signature.asc
Description: OpenPGP digital signature


Reply to: