[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#767870: cjk: FTBFS when there is space in LDFLAGS shell expansion



Package: cjk
Version: 4.8.3+git20140831-1
Severity: normal
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu vivid ubuntu-patch

Dear Maintainer,

In Ubuntu, the attached patch was applied to achieve the following:

  * debian/patches/03_Makefile.diff: Put quotes around the LDFLAGS so that
    it doesn't FTBFS with a space in them.

You can see the FTBFS here (Ubuntu has a quite verbose LDFLAGS): https://launchpad.net/ubuntu/+source/cjk/4.8.3+git20120914-2ubuntu1

Thanks for considering the patch.

Logan Rosen

-- System Information:
Debian Release: jessie/sid
  APT prefers vivid-updates
  APT policy: (500, 'vivid-updates'), (500, 'vivid-security'), (500, 'vivid'), (100, 'vivid-backports')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.16.0-24-generic (SMP w/1 CPU core)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
diff -Nru cjk-4.8.3+git20140831/debian/patches/03_Makefile.diff cjk-4.8.3+git20140831/debian/patches/03_Makefile.diff
--- cjk-4.8.3+git20140831/debian/patches/03_Makefile.diff	2014-10-05 03:47:40.000000000 -0400
+++ cjk-4.8.3+git20140831/debian/patches/03_Makefile.diff	2014-11-03 00:32:18.000000000 -0500
@@ -34,7 +34,7 @@
 +
 +utils/hbf2gf/hbf2gf:
 +	( cd utils/hbf2gf; \
-+         LDFLAGS=$(shell dpkg-buildflags --get LDFLAGS) ./configure --prefix=/usr \
++         LDFLAGS="$(shell dpkg-buildflags --get LDFLAGS)" ./configure --prefix=/usr \
 +               --with-kpathsea-lib=/usr/lib \
 +               --with-kpathsea-include=/usr/include \
 +               --mandir='$${prefix}/share/man'; \

Reply to: