[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#756761: marked as done (synctex_parser: memory leak in _synctex_open)



Your message dated Mon, 25 Aug 2014 03:37:24 +0000
with message-id <E1XLl5w-00006L-O4@franck.debian.org>
and subject line Bug#756761: fixed in texlive-bin 2014.20140825.35035-1
has caused the Debian Bug report #756761,
regarding synctex_parser: memory leak in _synctex_open
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
756761: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=756761
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Source: texlive-bin
Version: 2014.20140528.34243-5
Severity: normal
Tags: patch

There seems to be a memory leak in the implementation of _synctex_open.
build_output points to a memory location acquired with malloc, but build_output
is never passed to free. The attached patch adds the necessary calls to clean up
the allocated memory.

Cheers
-- 
Sebastian Ramacher
--- texlive-bin-2014.20140528.34243.orig/texk/web2c/synctexdir/synctex_parser.c
+++ texlive-bin-2014.20140528.34243/texk/web2c/synctexdir/synctex_parser.c
@@ -2878,6 +2878,7 @@ int _synctex_open(const char * output, c
 				build_output[0] = '\0';
 			} else {
 				if (build_output != strcpy(build_output,output)) {
+					free(build_output);
 					return -4;
 				}
 				build_output[lpc-output]='\0';
@@ -2886,15 +2887,20 @@ int _synctex_open(const char * output, c
 				/*	Append a path separator if necessary. */
 				if (!SYNCTEX_IS_PATH_SEPARATOR(build_output[strlen(build_directory)-1])) {
 					if (build_output != strcat(build_output,"/")) {
+						free(build_output);
 						return -2;
 					}
 				}
 				/*	Append the last path component of the output. */
 				if (build_output != strcat(build_output,lpc)) {
+					free(build_output);
 					return -3;
 				}
-				return __synctex_open(build_output,synctex_name_ref,file_ref,add_quotes,io_mode_ref);
+				int result = __synctex_open(build_output,synctex_name_ref,file_ref,add_quotes,io_mode_ref);
+				free(build_output);
+				return result;
 			}
+			free(build_output);
 		}
 		return -1;
 	}

Attachment: signature.asc
Description: Digital signature


--- End Message ---
--- Begin Message ---
Source: texlive-bin
Source-Version: 2014.20140825.35035-1

We believe that the bug you reported is fixed in the latest version of
texlive-bin, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 756761@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Norbert Preining <preining@debian.org> (supplier of updated texlive-bin package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Mon, 25 Aug 2014 10:57:04 +0900
Source: texlive-bin
Binary: texlive-binaries libkpathsea6 libkpathsea-dev libptexenc1 libptexenc-dev libsynctex1 libsynctex-dev luatex
Architecture: source amd64 all
Version: 2014.20140825.35035-1
Distribution: experimental
Urgency: medium
Maintainer: Debian TeX Maintainers <debian-tex-maint@lists.debian.org>
Changed-By: Norbert Preining <preining@debian.org>
Description:
 libkpathsea-dev - TeX Live: path search library for TeX (development part)
 libkpathsea6 - TeX Live: path search library for TeX (runtime part)
 libptexenc-dev - TeX Live: ptex encoding library (development part)
 libptexenc1 - TeX Live: pTeX encoding library
 libsynctex-dev - Tex Live: SyncTeX parser library (development part)
 libsynctex1 - TeX Live: SyncTeX parser library
 luatex     - TeX Live: transitional dummy package
 texlive-binaries - Binaries for TeX Live
Closes: 756761
Changes:
 texlive-bin (2014.20140825.35035-1) experimental; urgency=medium
 .
   * include current svn status targeting TL2015:
     - fixes memleak in synctex (Closes: #756761)
     - fixes for support CID-keyed OTF fonts in xdvipdfmx
Checksums-Sha1:
 28662d4f0c97a63f74e198a8e23eeff8d17808b8 2952 texlive-bin_2014.20140825.35035-1.dsc
 be6ffb1370c76af3d68e380d0f9acf9095ff8ad0 23077276 texlive-bin_2014.20140825.35035.orig.tar.xz
 a21e2ff01fa61637aa42ef30d43f11cd47e4b9f7 58208 texlive-bin_2014.20140825.35035-1.debian.tar.xz
 5532c756a36aa5493ed484504c83eeab924f0029 6817554 texlive-binaries_2014.20140825.35035-1_amd64.deb
 824f9110fe1628ede97e4a841a7fc4ff2ba17a43 153118 libkpathsea6_2014.20140825.35035-1_amd64.deb
 72069950dbe78dcccedd227bbbe04864c0d14bb9 179570 libkpathsea-dev_2014.20140825.35035-1_amd64.deb
 72e2314a1b45d3caab096dd0b636119f7074eb1f 53582 libptexenc1_2014.20140825.35035-1_amd64.deb
 824147dc27bc064ff867e0217aa7edfb9b8213e2 52846 libptexenc-dev_2014.20140825.35035-1_amd64.deb
 0cfb035202e3d09b706ec86e4aab7805fa503bb4 60508 libsynctex1_2014.20140825.35035-1_amd64.deb
 def90cacf1e8ebbf0d0625a58be37eaf186fe36e 58548 libsynctex-dev_2014.20140825.35035-1_amd64.deb
 4ddc01f4b87aa6ff50eca7012b0f5a82b89e32c8 27310 luatex_2014.20140825.35035-1_all.deb
Checksums-Sha256:
 b746da9493e62e4dd7c55720b978a894249a375c2275658035305bee775b8ce3 2952 texlive-bin_2014.20140825.35035-1.dsc
 cc58f073394823511894dacaccf9eea98b72b06aff4be8624b2132741a359187 23077276 texlive-bin_2014.20140825.35035.orig.tar.xz
 1c2d3aebc705903564e62db91e28585d28d973b5b0352ad99535366804c30ca1 58208 texlive-bin_2014.20140825.35035-1.debian.tar.xz
 f73f526fa6bfc66127ac73e84bf45f58466e3f1fa3fab7db766b3e3eaed05575 6817554 texlive-binaries_2014.20140825.35035-1_amd64.deb
 1a31cf8cd25dba546b721a038de0a0ab86e69ba02cc86c944fdb6d5f1150700a 153118 libkpathsea6_2014.20140825.35035-1_amd64.deb
 8739572cf07205b132dc9ed344863cc56de00f65a630f07bc87c760fc60a7de2 179570 libkpathsea-dev_2014.20140825.35035-1_amd64.deb
 8f9249a50ef3358f7cbdab347cba8ecf394233e22ae66646c909a3a9551c0e33 53582 libptexenc1_2014.20140825.35035-1_amd64.deb
 36502afb5450dcb596f52a6bc7226b024d6833b452db9f26e32f31990fbedbcf 52846 libptexenc-dev_2014.20140825.35035-1_amd64.deb
 20afc78191e43ac3e86276ae6f71e241d174defa6826b2a64521d35e8b7b0309 60508 libsynctex1_2014.20140825.35035-1_amd64.deb
 40d069f5e4d5651b81a4ed3fddb634d0e9694e07000defc4797599985c525e36 58548 libsynctex-dev_2014.20140825.35035-1_amd64.deb
 b8ea7e8f625ac598a288f59de1a889e0e02a5d7833fb75856e38e146a7b3a60b 27310 luatex_2014.20140825.35035-1_all.deb
Files:
 a2394f1663af8431f591b8136185ae22 6817554 tex optional texlive-binaries_2014.20140825.35035-1_amd64.deb
 dfa7fd7d1fc8ecbdcb854c3c5bc4bb87 153118 libs optional libkpathsea6_2014.20140825.35035-1_amd64.deb
 67a10dad46bd4c42e2b6cc38f11a9d55 179570 libdevel optional libkpathsea-dev_2014.20140825.35035-1_amd64.deb
 d3ece6d77c52b1a472c4267569bb3c22 53582 libs optional libptexenc1_2014.20140825.35035-1_amd64.deb
 dedb427be4207272a6922c562b2e025e 52846 libdevel optional libptexenc-dev_2014.20140825.35035-1_amd64.deb
 4beb44968d267f64589a5b6897397dab 60508 libs optional libsynctex1_2014.20140825.35035-1_amd64.deb
 5edf83059b3e073b3bcdb4f015439dc5 58548 libdevel optional libsynctex-dev_2014.20140825.35035-1_amd64.deb
 8140391ade7f3dcf8e53d2970b46cbd4 27310 oldlibs extra luatex_2014.20140825.35035-1_all.deb
 3841241378c38b49b9d77e577441d890 2952 tex optional texlive-bin_2014.20140825.35035-1.dsc
 a8349e09c27ce4ecd9a052bf520c74ab 23077276 tex optional texlive-bin_2014.20140825.35035.orig.tar.xz
 80eae737ea5a6469164aabccc1ebebd4 58208 tex optional texlive-bin_2014.20140825.35035-1.debian.tar.xz

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIVAwUBU/qdrmyspEiGDNwTAQjiow/+K7fD7FlsUGFCvZ3w1Z3e9LXb5eVtq+uG
RbotvkaDKLTFJ9qYMEIj5VTovZZWYOnRFIXzAzxApSocPevfk93EggY+ZJUyZr7X
BSN0W7TJadxYlwD6nLmObW2XQ7L9RtCeJuN7tc8X6Y/UKLytq7pJEBXPiM7RzepV
Ukb9LnK/cw7hyX57aRk68dKeLe2UyawH4AaM662VNN1P0iUaF7pHgmxv3G7RgjhM
bXqvRqCcGqAp/iKYXtdektXlhiEebigS2FqBPeixUGbEg3y4tJvjvQuTFyD0bJyT
gXxPl1UvbufqIYTf3EnOekF3+4oH0YszR21tt5Y+yNlNMEsviH/c75E4Gvb79atN
A14mecd4KHCAKH8tTGdRmVH7VbciYFy1L2LKatETdZLoujTpxPRbdgwWWNNRDy5w
7mdzWvteSUoz/yw62YTYbUnVZWGhJDUYEK+Tc+FVth335ErqUWG4J5WQmi72aaFe
LYS6itt6hn9vMo+PBjhG5h6GjXUtbRiUUenmCTxvfwx82bSaXwEQKce+DNGEt+53
O/WhWhRk+5EVHToAyKIUipqS3XNIMuxIe0E2CN3I5GxbgHxRr+BjFzyIjHnRNbe+
wyCo4xofm6cX3Np7tDheByABzL70EEqFlpvcpiB/oD0uVOgcGGQ64Do3BTzyUw5d
smysm7L6lmw=
=dC0F
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: