[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#763711: texlive-bin: FTBFS on arm64



Package: texlive-bin
Version: 2014.20140926.35254-1
Severity: normal
Tags: patch
User: debian-arm@lists.debian.org
Usertag: arm64

This version of texlive-bin does not build on arm64 due to the
internal libpng trying to use 32-bit neon code (neon is ARM SIMD
unit). The attached simple patch correctly restricts that code to the
right architectures.

There is actually a C intrinsics Neon implemention in the libpng which
could be used for arm64, but that would involve more work, and for an
internal libpng inside texlive does not seem worth the effort,
especially at this stage of the release cycle.

I presume there is a good reason why this package has its own libpng
and is not using the system one (where this issue should already be
fixed)?  (or maybe it is but the internal one gets built anyway?)

Anyway, a quick upload with this fix would be appreciated to get
texlive-bin up to date in the arm64 architecture which is currently
planned to be released with Jessie. I'm happy to NMU if you prefer.

thanks for your work with this epic package!

Wookey
diff -Nru texlive-bin-2014.20140926.35254/debian/changelog texlive-bin-2014.20140926.35254/debian/changelog
--- texlive-bin-2014.20140926.35254/debian/changelog	2014-09-26 05:00:45.000000000 +0000
+++ texlive-bin-2014.20140926.35254/debian/changelog	2014-10-01 21:31:10.000000000 +0000
@@ -1,3 +1,10 @@
+texlive-bin (2014.20140926.35254-1.1) unstable; urgency=low
+
+  * Non-maintainer upload.
+  * Fix arm64 build by correctly qulifying neon code
+
+ -- Wookey <wookey@debian.org>  Wed, 01 Oct 2014 21:22:00 +0000
+
 texlive-bin (2014.20140926.35254-1) unstable; urgency=medium
 
   * Imported Upstream version 2014.20140926.35254
diff -Nru texlive-bin-2014.20140926.35254/debian/patches/libpng-arm64-neon-fix texlive-bin-2014.20140926.35254/debian/patches/libpng-arm64-neon-fix
--- texlive-bin-2014.20140926.35254/debian/patches/libpng-arm64-neon-fix	1970-01-01 00:00:00.000000000 +0000
+++ texlive-bin-2014.20140926.35254/debian/patches/libpng-arm64-neon-fix	2014-10-01 22:24:23.000000000 +0000
@@ -0,0 +1,22 @@
+Description: Fix FTBFS on arm64
+ Use correct defines for selecting 32-bit neon assembler code in 
+ embedded libpng, so that it is not used on 64-bit armv8.
+ .
+ texlive-bin (2014.20140926.35254-1.1) unstable; urgency=low
+ .
+   * Non-maintainer upload.
+   * Fix arm64 build by correctly qulifying neon code
+Author: Wookey <wookey@debian.org>
+Last-Update: 2014-09-30
+
+--- texlive-bin-2014.20140926.35254.orig/libs/libpng/libpng-1.6.13/pngpriv.h
++++ texlive-bin-2014.20140926.35254/libs/libpng/libpng-1.6.13/pngpriv.h
+@@ -124,7 +124,7 @@
+     * check both variants.
+     */
+ #  if (defined(__ARM_NEON__) || defined(__ARM_NEON)) && \
+-   defined(PNG_ALIGNED_MEMORY_SUPPORTED)
++   defined(PNG_ALIGNED_MEMORY_SUPPORTED) && defined(__arm__)
+ #     define PNG_ARM_NEON_OPT 2
+ #  else
+ #     define PNG_ARM_NEON_OPT 0
diff -Nru texlive-bin-2014.20140926.35254/debian/patches/series texlive-bin-2014.20140926.35254/debian/patches/series
--- texlive-bin-2014.20140926.35254/debian/patches/series	2014-09-26 05:00:45.000000000 +0000
+++ texlive-bin-2014.20140926.35254/debian/patches/series	2014-10-01 22:16:27.000000000 +0000
@@ -11,3 +11,4 @@
 upupstream-fix-pdf_h-query-svn5018
 upupstream-fix-math-list-crash-svn5019
 upupstream-bug907-svn5024
+libpng-arm64-neon-fix

Reply to: