tag 665456 + patch thanks Hi, Alle sabato 24 marzo 2012, Hilmar Preusse ha scritto: > The Hurd hurts us ;-) . (it's more like relying on paths no more longer than "PATH_MAX" that does ;) ) > ptexenc does not build. > > libtool: compile: gcc -DHAVE_CONFIG_H -I. -I../../../texk/ptexenc > -I./ptexenc > -I/build/buildd-texlive-bin_2011.20120322-1-hurd-i386-QeUDGl/texlive- > bin-2011.20120322/Work/texk > -I/build/buildd-texlive-bin_2011.20120322-1-hurd-i386-QeUDGl/texlive > -bin-2011.20120322/texk -DMAKE_PTENC_DLL -Wimplicit -Wreturn-type > -Wdeclaration-after-statement -Wno-unknown-pragmas -g -O2 -c > ../../../texk/ptexenc/ptexenc.c -fPIC -DPIC -o > .libs/libptexenc_la-ptexenc.o > ../../../texk/ptexenc/ptexenc.c: In function 'nkf_open': > ../../../texk/ptexenc/ptexenc.c:762:15: error: 'PATH_MAX' undeclared > (first use in this function) ../../../texk/ptexenc/ptexenc.c:762:15: > note: each undeclared identifier is reported only once for each > function it appears in > > This is a very common software bug; it should not be hard to fix it. > I'll care about it. The patch I have (attached) is just including a "compatibility" header of kpathsea which defines PATH_MAX somehow if not defined already. This approach is used all around in texlive, so I went for it (even if the ideal solution would be drop that header and not rely on PATH_MAX anymore...). Alle martedì 27 marzo 2012, Norbert Preining ha scritto: > On Mo, 26 MÀr 2012, Hilmar Preusse wrote: > > Please don't delay the upload for this. > > It does not make sense, since the transition to testing is anyway > blocked by the FTBFS, so we have to solve both ;-) Note that Hurd-specific issues cannot be more than "important" (like this bug is), since hurd-i386 is not a release architecture, so they don't block testing migration anyway. (Ah, unrelated note: when producing a new orig.tar.gz, can you please remove the .svn directories from it? So its size will be half.) Thanks, -- Pino Toscano
--- a/texk/ptexenc/ptexenc.c +++ b/texk/ptexenc/ptexenc.c @@ -7,6 +7,7 @@ #include <kpathsea/variable.h> #include <kpathsea/readable.h> #include <kpathsea/c-limits.h> +#include <kpathsea/c-pathmx.h> #include <ptexenc/c-auto.h> #include <ptexenc/ptexenc.h>
Attachment:
signature.asc
Description: This is a digitally signed message part.