[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#659608: marked as done (lmodern: use dh_installdeb maintscript support)

Your message dated Wed, 07 Mar 2012 03:22:19 +0000
with message-id <E1S57SF-00075d-1t@franck.debian.org>
and subject line Bug#659608: fixed in lmodern 2.004.1-4
has caused the Debian Bug report #659608,
regarding lmodern: use dh_installdeb maintscript support
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
659608: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=659608
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: lmodern
Version: 2.004.1-3.1
Severity: wishlist
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch precise

Using 'dpkg-maintscript-helper supports rm_conffile' guards introduces
unreliability into upgrades; it means that the conffile is removed or
not depending on whether dpkg happens to be unpacked before lmodern.
This seems generally undesirable; it would be better to enforce a single
code path.  (This is academic for Debian because the version of dpkg in
squeeze supported dpkg-maintscript-helper, hence Severity: wishlist;
Ubuntu's last LTS release didn't have a sufficient version of dpkg for
that which is why I care.)

It would be nice to just use dh_installdeb's support for generating
dpkg-maintscript-helper commands, which was introduced in debhelper
8.1.0.  This would remove duplicate code from your maintainer scripts -
in fact, you'd no longer need to have a handwritten postinst at all.
Here's a patch:

  * Use maintscript support in dh_installdeb rather than writing out
    dpkg-maintscript-helper commands by hand.  We now simply Pre-Depend on a
    new enough version of dpkg rather than using 'dpkg-maintscript-helper
    supports' guards, leading to more predictable behaviour on upgrades.

diff -u lmodern-2.004.1/debian/control lmodern-2.004.1/debian/control
--- lmodern-2.004.1/debian/control
+++ lmodern-2.004.1/debian/control
@@ -3,7 +3,7 @@
 Priority: optional
 Maintainer: Debian TeX maintainers <debian-tex-maint@lists.debian.org>
 Uploaders: Julian Gilbey <jdg@debian.org>, C.M. Connelly <cmc@debian.org>, Atsuhito KOHDA <kohda@debian.org>, Frank Küster <frank@debian.org>, Florent Rougon <frn@debian.org>, Norbert Preining <preining@debian.org>
-Build-Depends: debhelper (>= 7)
+Build-Depends: debhelper (>= 8.1.0~)
 Build-Depends-Indep: tex-common (>= 1.18)
 Standards-Version: 3.8.3
 Vcs-Svn: svn://svn.debian.org/svn/debian-tex/lmodern/trunk
@@ -13,6 +13,7 @@
 Package: lmodern
 Section: fonts
 Architecture: all
+Pre-Depends: ${misc:Pre-Depends}
 Depends: ${misc:Depends}
 Conflicts: lm, lmodern-x11, context (<= 2008.10.31-1)
 Replaces: lm, lmodern-x11
reverted:
--- lmodern-2.004.1/debian/lmodern.postinst
+++ lmodern-2.004.1.orig/debian/lmodern.postinst
@@ -1,11 +0,0 @@
-#! /bin/sh -e
-
-
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/lmodern.hints 2.004.1-3.1 -- "$@"
-fi
-
-
-#DEBHELPER#
-
-exit 0
diff -u lmodern-2.004.1/debian/lmodern.preinst lmodern-2.004.1/debian/lmodern.preinst
--- lmodern-2.004.1/debian/lmodern.preinst
+++ lmodern-2.004.1/debian/lmodern.preinst
@@ -248,11 +248,6 @@
 fi
 
 
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/lmodern.hints 2.004.1-3.1 -- "$@"
-fi
-
-
 #DEBHELPER#
 
 exit 0
diff -u lmodern-2.004.1/debian/lmodern.postrm lmodern-2.004.1/debian/lmodern.postrm
--- lmodern-2.004.1/debian/lmodern.postrm
+++ lmodern-2.004.1/debian/lmodern.postrm
@@ -55,10 +55,6 @@
         ;;
 esac
 
-if dpkg-maintscript-helper supports rm_conffile 2>/dev/null; then
-  dpkg-maintscript-helper rm_conffile /etc/defoma/hints/lmodern.hints 2.004.1-3.1 -- "$@"
-fi
-
 
 #DEBHELPER#
 
only in patch2:
unchanged:
--- lmodern-2.004.1.orig/debian/lmodern.maintscript
+++ lmodern-2.004.1/debian/lmodern.maintscript
@@ -0,0 +1 @@
+rm_conffile /etc/defoma/hints/lmodern.hints 2.004.1-3.1

Thanks,

-- 
Colin Watson                                       [cjwatson@ubuntu.com]

--- End Message ---
--- Begin Message --- 
Source: lmodern
Source-Version: 2.004.1-4

We believe that the bug you reported is fixed in the latest version of
lmodern, which is due to be installed in the Debian FTP archive:

lmodern_2.004.1-4.diff.gz
  to main/l/lmodern/lmodern_2.004.1-4.diff.gz
lmodern_2.004.1-4.dsc
  to main/l/lmodern/lmodern_2.004.1-4.dsc
lmodern_2.004.1-4_all.deb
  to main/l/lmodern/lmodern_2.004.1-4_all.deb



A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 659608@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Norbert Preining <preining@debian.org> (supplier of updated lmodern package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Format: 1.8
Date: Mon, 05 Mar 2012 09:47:26 +0900
Source: lmodern
Binary: lmodern
Architecture: source all
Version: 2.004.1-4
Distribution: experimental
Urgency: low
Maintainer: Debian TeX maintainers <debian-tex-maint@lists.debian.org>
Changed-By: Norbert Preining <preining@debian.org>
Description: 
 lmodern    - scalable PostScript and OpenType fonts based on Computer Modern
Closes: 659608
Changes: 
 lmodern (2.004.1-4) experimental; urgency=low
 .
   [ Hilmar Preuße ]
   * Use maintscript support in dh_installdeb rather than writing out
     dpkg-maintscript-helper commands by hand. Thanks to Colin Watson
     (Closes: #659608)
 .
   [ Norbert Preining ]
   * fix maintscript to use the right version number for removing
     defoma config file
   * tex-common v3 build for TL2012, bump build-deps
   * bump standards version to 3.9.3, no changes needed
Checksums-Sha1: 
 b188fa47267dcee676edf61f551bbd9589da8dc0 1475 lmodern_2.004.1-4.dsc
 216bf84d2e7de7df82e1fca805e4d504dee66914 24500 lmodern_2.004.1-4.diff.gz
 4ad771b00d2e8bdef7aa2650200929e627b6de64 18198150 lmodern_2.004.1-4_all.deb
Checksums-Sha256: 
 8a27a391ef3414fd020222e1cf8ea15b737d1f8a32f8a5673bb2cdd9e15c6f5e 1475 lmodern_2.004.1-4.dsc
 3d70f60f560cc211e37ae90eb6cefc81c8c2b989624ef62836f5174c806b9753 24500 lmodern_2.004.1-4.diff.gz
 98ffff93210b8b0b9ffe432dad748ad0ab8d5dcbbd53e88e34d7859cd54db36c 18198150 lmodern_2.004.1-4_all.deb
Files: 
 effefaf4ad09b513688ea21f10bdfef7 1475 fonts optional lmodern_2.004.1-4.dsc
 a1fc3a8d6102e19296d56adef8a73d92 24500 fonts optional lmodern_2.004.1-4.diff.gz
 09c60a5dc1f42835dcdc0f739f46bffc 18198150 fonts optional lmodern_2.004.1-4_all.deb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.12 (GNU/Linux)

iD8DBQFPVCvF0r9KownFsJQRAvb2AKCOMAoo5pRHYgVrVhZ1KSIA9I1m0wCfUQni
44sxKTdldS+pqy6vukbz4LE=
=I93H
-----END PGP SIGNATURE-----

--- End Message ---
Reply to: