--- Begin Message ---
- To: submit@bugs.debian.org
- Subject: texlive-bin: try_open_mode sometimes fails to pass mode to open
- From: Colin Watson <cjwatson@ubuntu.com>
- Date: Sun, 20 Feb 2011 17:57:57 +0000
- Message-id: <20110220175757.GO29629@riva.ucam.org>
Package: texlive-bin
Version: 2009-8
Severity: important
Tags: patch
User: ubuntu-devel@lists.ubuntu.com
Usertags: origin-ubuntu ubuntu-patch natty
texlive-bin failed to build on Ubuntu ppc64 (still an experimental port,
but this doesn't seem to be architecture-specific - I suspect that it
only shows up as a compile-time error at -O3):
In file included from /usr/include/fcntl.h:252:0,
from /usr/include/sys/file.h:25,
from ../../../texk/xdvik/util.c:33:
In function 'open',
inlined from 'try_open_mode.clone.1' at ../../../texk/xdvik/util.c:276:5,
inlined from 'xdvi_temp_fd' at ../../../texk/xdvik/util.c:869:5:
/usr/include/bits/fcntl2.h:51:24: error: call to '__open_missing_mode' declared with attribute error: open with O_CREAT in second argument needs 3 arguments
This seems to be a genuine bug that could cause files to be created with
undefined modes in the EMFILE/ENFILE error handling path. Here's a
patch:
* In try_open_mode, pass the mode on to open even in the EMFILE/ENFILE
case.
diff -u texlive-bin-2009/debian/patches/series texlive-bin-2009/debian/patches/series
--- texlive-bin-2009/debian/patches/series
+++ texlive-bin-2009/debian/patches/series
@@ -35,0 +36 @@
+try-open-mode-fix
only in patch2:
unchanged:
--- texlive-bin-2009.orig/debian/patches/try-open-mode-fix
+++ texlive-bin-2009/debian/patches/try-open-mode-fix
@@ -0,0 +1,18 @@
+Description: Pass mode on to open even in EMFILE/ENFILE case
+Author: Colin Watson <cjwatson@ubuntu.com>
+Forwarded: no
+Last-Update: 2011-02-20
+
+Index: b/texk/xdvik/util.c
+===================================================================
+--- a/texk/xdvik/util.c
++++ b/texk/xdvik/util.c
+@@ -273,7 +273,7 @@
+ int fd = open(fname, flags, mode);
+ if (fd < 0 && (errno == EMFILE || errno == ENFILE)) {
+ close_a_file();
+- fd = open(fname, flags);
++ fd = open(fname, flags, mode);
+ }
+ return fd;
+ }
Thanks,
--
Colin Watson [cjwatson@ubuntu.com]
--- End Message ---
--- Begin Message ---
Source: texlive-bin
Source-Version: 2009-10
We believe that the bug you reported is fixed in the latest version of
texlive-bin, which is due to be installed in the Debian FTP archive:
libkpathsea-dev_2009-10_i386.deb
to main/t/texlive-bin/libkpathsea-dev_2009-10_i386.deb
libkpathsea5_2009-10_i386.deb
to main/t/texlive-bin/libkpathsea5_2009-10_i386.deb
texlive-bin_2009-10.diff.gz
to main/t/texlive-bin/texlive-bin_2009-10.diff.gz
texlive-bin_2009-10.dsc
to main/t/texlive-bin/texlive-bin_2009-10.dsc
texlive-binaries_2009-10_i386.deb
to main/t/texlive-bin/texlive-binaries_2009-10_i386.deb
A summary of the changes between this version and the previous one is
attached.
Thank you for reporting the bug, which will now be closed. If you
have further comments please address them to 614257@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.
Debian distribution maintenance software
pp.
Frank Küster <frank@debian.org> (supplier of updated texlive-bin package)
(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@debian.org)
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.8
Date: Thu, 28 Jul 2011 21:54:49 +0200
Source: texlive-bin
Binary: texlive-binaries libkpathsea5 libkpathsea-dev
Architecture: source i386
Version: 2009-10
Distribution: unstable
Urgency: low
Maintainer: Debian TeX Maintainers <debian-tex-maint@lists.debian.org>
Changed-By: Frank Küster <frank@debian.org>
Description:
libkpathsea-dev - TeX Live: path search library for TeX (development part)
libkpathsea5 - TeX Live: path search library for TeX (runtime part)
texlive-binaries - Binaries for TeX Live
Closes: 136051 593782 614257 618033
Changes:
texlive-bin (2009-10) unstable; urgency=low
.
[ Hilmar Preusse ]
* xdvik compilation error with glibc-2.10 and gcc-4.4:
xdvik-22.84.16-open-mode.patch (Closes: #614257)
* comment the --disable-largefile switch in upstream build script
(partial_lfs_support.diff). This hopefully (Closes: #618033). dvips
still can't write files > 2GB (see #383781).
* we can use gcc-4.5 on armel too
.
[ Frank Küster ]
* Indicate in the description that this package needs a real TeX package
to function, and add a Recommends on texlive-base (closes: #593782)
* Make various upstream-provided scripts "set -e". This closes: #136051
and is needed by the planned papersize patch to texconfig.
* The binaries pdftex, dvips, xdvi and dvipdfmx now respect the
system-wide paper setting as their default if there is no papersize
information in the input file (see #49149). It is still highly
recommended to specify such information explicitly, e.g. using
hyperref.sty with LaTeX.
Checksums-Sha1:
05a821fab11c05eee03d68712231e94008cbfe31 1391 texlive-bin_2009-10.dsc
400d173f5bbcece9c91c2683322513b20f7b9632 91107 texlive-bin_2009-10.diff.gz
de626f870a5f6f7e990afbe9038dc8ff10c2bc4a 7684754 texlive-binaries_2009-10_i386.deb
8d5ff314a96f2166bac0b0ab8eda6bb74be8f475 134884 libkpathsea5_2009-10_i386.deb
b22df29ac07f67c50191b8f49109c757643518a4 173934 libkpathsea-dev_2009-10_i386.deb
Checksums-Sha256:
90da4f31a16f179548e156d092776c7ef81c8b53988eb304d4d6be3049d2e1f2 1391 texlive-bin_2009-10.dsc
82833e243935392f18eaebcbcd557eb1a64ea36703fa489b8d2366ae5db911c0 91107 texlive-bin_2009-10.diff.gz
39a7c954f4890a38406c69813c0fed1052c333bf9aab01f93614dedc3849f46d 7684754 texlive-binaries_2009-10_i386.deb
149fc450be78e4f8780db604c6be87d05371cb1f2f3ce6e9ad8a2380fe359a5d 134884 libkpathsea5_2009-10_i386.deb
3147d3d04c4416f429054bb0826545d18afecc5a553fa7b43ead44bc1a4fc5cb 173934 libkpathsea-dev_2009-10_i386.deb
Files:
1fb5cb3c43dbc0f71a92bc48f6fc519c 1391 tex optional texlive-bin_2009-10.dsc
3f4fc7e694afdff5a29b724882b9a958 91107 tex optional texlive-bin_2009-10.diff.gz
809c32c470792626e4eead3c55054d3e 7684754 tex optional texlive-binaries_2009-10_i386.deb
a3efa4e46ee5d4b5e0eda294f08eec65 134884 libs optional libkpathsea5_2009-10_i386.deb
b7e09c806be66f80b5117a949511843b 173934 libdevel optional libkpathsea-dev_2009-10_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.10 (GNU/Linux)
iEYEARECAAYFAk43F3cACgkQ+xs9YyJS+hqk2ACeMuvBswqGTp+werbUJtDCaJDJ
7GEAoIRz4v8sBEG6ud0odYqTD7qrz8bt
=WDre
-----END PGP SIGNATURE-----
--- End Message ---