[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#441595: not all libraries are customized, there is room for improvement



On 17.12.09 Enrico Tassi (gareuselesinge@debian.org) wrote:

Hi,

> I offer my help in pushing the needed patches upstream, but I'll do
> that only if luatex upstreams agree on updating some of their libs
> and the Debian maintaner to remove the wontfix tag :-)
> 
I'll ask Taco, whether he has already an opinion regarding the patch
for luafilesystem.

I got a very fast response from Taco:

<snip>
I now am in the process of upgrading luatex to use luafilesystem
1.5.0, and I will move most of the extra functionality to a different
source file, as I wrote above.

Nevertheless, there are two change sets that will remain in my
version of the lfs.c file: one portability bug fix and one extension.
Both of these are interesting enough to go upstream, in my opinion.

The portability fix is in get_dir(), where the stock lfs version
assumes a glibc-style runtime library that calls malloc()
automatically inside getcwd(). I got a compilation failure report on
that, for the Sun Studio compiler on Solaris 10 Sparc.

The extension is an extra field thats is retunred by
lfs.attributes(), named 'permissions'. This represents the file
permissions as a simple 9-letter string (it uses "r", "w", and "x"
only).
<snap>

A patch was attached: http://bugs.debian.org/cgi-bin/bugreport.cgi?msg=127;filename=lfs.c.diff;att=1;bug=441595

So go ahead and push the patches to upstream. For now I remove the
wontfix tag from luatex. I'll open a wishlist bug against
liblua5.1-filesystem0 and mark it as blocking our bug.

Thanks,
  Hilmar
-- 
sigmentation fault



Reply to: