On Wed, Jun 27, 2007 at 05:31:49PM +0200, Frank Küster wrote:
> Eythan Weg <weg@indiscrete.org> wrote:
> From src/libs/luazlib/lzlib.c:
> /* make sure header and library version are consistent */
> const char* version = zlibVersion();
> if (strcmp(version, ZLIB_VERSION))
> {
> Hm, does this make sense? Shouldn't libtool, proper dependencies and,
> in an ideal world, versioned symbols be used for such checks?
I don't know about the lua bindings but zlib supports a vast range of
platforms only some of which support such things.
> Or should the zlib authors be lart^w politely critized to not use a
> forth level of numbering beyond REVISION?
I don't see why that would help at all? If you're going to do an exact
match on the version number then it's going to break eventually.
> Is it safe to assume that the authors of lzlib.c are just over-careful,
> and we can replace the hardcoded version with our current one (after
> checking that the shlibs information for zlib didn't change, of course)?
Yes, zlib does offer a stable ABI so checking for the exact version
number is excessive. For what it's worth the checks inside zlib compare
only the first character of the string. Comparing for a lower version
would also work.
--
"You grabbed my hand and we fell into it, like a daydream - or a fever."
Attachment:
signature.asc
Description: Digital signature