Bug#437949: texlive-bin: FTBFS on hurd-i386 because of icu
Hi,
Norbert Preining, le Fri 31 Aug 2007 20:47:50 +0200, a écrit :
> On Die, 28 Aug 2007, Michael Casadevall wrote:
> > Independently of Samuel, I ended up patching the same bug in Texlive,
> > but I did a different method of fixing
>
> On Mit, 29 Aug 2007, Samuel Thibault wrote:
> > That should rather be sizeof(FILE*): rgfp is an array of FILE*, not an
> > array of FILE.
> >
> > Also, sysconf() may return -1 when there is no actual limit on the
> > number of opened files, your patch doesn't cope with this.
>
> So can one of you two tell me which patch would be better to be
> included?
Well, either should work fine for hurd-i386 because it happens that
sizeof(FILE) > sizeof(FILE*) and on hurd-i386, sysconf() doesn't return
-1, so Michael's patch actually works, but it's only by chance.
Mine is much less intrusive. Upstream will probably prefer to switch to
a dynamically allocated array.
Samuel
Reply to: