Bug#382861: Updating Sarge teTeX to etch/sid TeX live ... help

[Florent Rougon <f.rougon@free.fr>]

Hi,

Norbert Preining <preining@logic.at> wrote:

> What about adding the following code to the preinst code of all texlive
> packages in the upgrade|install part?
>
>     # check for the presence of tetex2 packages by checking for
>     # /etc/texmf/fmt.d/00tetex.cnf
>     if [ -r /etc/texmf/fmt.d/00tetex.cnf ] ; then
>       echo "You are upgrading from teTeX 2." >&2
>       echo "We move the following conflicting config files to file.disabled," >&2

I would suggest using .tetex2 or .teTeX2 instead of .disabled, so that
the reason why the files were disabled is obvious from their name.

>       echo "After successfull installation you can remove these files." >&2
>       echo "  /etc/texmf/fmt.d/00tetex.cnf  -> 00tetex.cnf.disabled" >&2
>       echo "  /etc/texmf/updmap.d/00updmap.cfg -> 00updmap.cfg.disabled" >&2
>       echo " " >&2

Why echo a space? Why not simply 'echo >&2'?

>       echo "It would be a good idea to purge all the tetex packages!" >&2

>       mv /etc/texmf/fmt.d/00tetex.cnf /etc/texmf/fmt.d/00tetex.cnf.disabled

I would move this line last because otherwise, your snippet isn't
idempotent: suppose we get past this mv command and then, dpkg is
interrupted. When the script is rerun, the first test
[ -r /etc/texmf/fmt.d/00tetex.cnf ] will fail and therefore, the old
00updmap.cfg won't me moved out of the way.

So, I suggest mv'ing 00updmap.cfg *before* 00tetex.cnf.

-- 
Florent