Re: libpoppler removing unnecessary parts

[Frank Küster <frank@kuesterei.ch>]

Norbert Preining <preining@logic.at> wrote:

> Hi Frank!
>
> An interdiff between the old patch-poppler and the new after your
> checking shows:
> -LDFLAGS = -lpoppler
>
> Are you sure you don't need -lpoppler? Where is this library than added?
> In the rules.in files there is no LDFLAGS setting anymore! It is
> commented out.
>
> Thus I assume that -lpoppler will not be added at all.

I'm sure the line is not needed - in fact it has no effect, and the hard
part was finding out why.  It turns out that for compilation of the
individual object files, web2c/pdftexdir/Makefile is used, whereas for
linking, the snippets pdf{,e,x}texdir/pdf{,e,x}tex.mk have to be changed
(they are included in web2c/Makefile which is then used for the
linker/libtool calls).

So the place where -lpopper is added is this hunk

+# use libpoppler instead of included xpdf code
+ADDLDFLAGS = -lpoppler
+
 # We build pdftex
 pdftex = @PTEX@ pdftex
 pdftexdir = pdftexdir
@@ -29,7 +32,7 @@
 
 # Making pdftex
 pdftex: $(pdftex_o) $(pdftexextra_o) $(pdftexlibsdep)
-	@CXXHACKLINK@ $(pdftex_o) $(pdftexextra_o) $(pdftexlibs) $(socketlibs) @CXXHACKLDLIBS@ @CXXLDEXTRA@
+	@CXXHACKLINK@ $(pdftex_o) $(pdftexextra_o) $(pdftexlibs) $(socketlibs) @CXXHACKLDLIBS@ @CXXLDEXTRA@ $(ADDLDFLAGS)

which occurs similarly in all three files.

Regards, Frank
-- 
Frank Küster
Inst. f. Biochemie der Univ. Zürich
Debian Developer