[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#264241: Some corrections regardings statements in this bug



Hi,

Hilmar Preusse <hille42@web.de> wrote:

> Patch attached. Frank, is that a good idea?

[...]

> +if [ x"$1" = "xremove" -o x"$1" = "xupgrade" ]; then

*Now* we have a bashism. :)

-o and -a in tests are XSI extensions; not POSIX. You should use
something like:

+if [ x"$1" = "xremove" ] || [ x"$1" = "xupgrade" ]; then

(and I would even drop the x thingies 'cause I don't think they are of
any use these days...)

-- 
Florent



Reply to: