Bug#127005: package is broken on arm, powerpc and s390 due to wrong assumption on char signedness

[Adrian Bunk <bunk@fs.tum.de>]

On Tue, 1 Jan 2002, Gerhard Tonn wrote:

> > These three are not necessarily bugs, though the code should be looked
> > over to be certain.
> >
>
> I think these are bugs. See code fragments below.
>
>
>  if ((succ_index=T1_GetEncodingIndex( FontID, (char*) ligs->succ))==-1) {
>       /* successor is not current encoding */
>       ligs=ligs->next;
>       continue;
>     }
>
> if ((lig_index=T1_GetEncodingIndex( FontID, (char*) ligs->lig))==-1) {
>       /* Specified ligature is not in current encoding */
>       ligs=ligs->next;
>       continue;
>     }
>...

Some comments on this:

- These fragments are in libs/t1lib/t1finfo.c which is a local (upstream)
  copy of the library in the t1lib package.

- succ_index and lig_index are int instead of char in t1lib-1.3.1 (not yet
  packaged for Debian):

--- /home/bunk/Debian/tetex/tetex-bin-1.0.7+20011202/libs/t1lib/t1finfo.c	Sun Oct 14 20:14:23 2001
+++ lib/t1lib/t1finfo.c	Sun May 27 05:40:11 2001
@@ -510,9 +510,9 @@
   char *c_name;
   char cc_name[128];
   static char succ[MAX_LIGS];
-  char succ_index;
+  int succ_index;
   static char lig[MAX_LIGS];
-  char lig_index;
+  int lig_index;

   Ligature *ligs;
   int i,j;

- The only reason why we use this local copy is that building teTeX with
  "--with-system-t1lib" which would use the shared library from the t1lib1
  package seems to be currently broken (I've already reported this to the
  tetex-pretest list).


I've CC'ed David Huggins-Daines who maintains the Debian package of t1lib
and I'll forward it to the tetex-pretest list to get it fixed in the next
upstream teTeX package.


> Regards,
> Gerhard


cu
Adrian