Bug#63451: marked as done (tetex-bin: Comparison is always false errors in tftopl and vftovp; patch enclosed)
Your message dated Sun, 3 Jun 2001 21:23:20 +0200 (CEST)
with message-id <Pine.NEB.4.33.0106032121470.13929-100000@mimas.fachschaften.tu-muenchen.de>
and subject line Fixed in tetex-bin 1.0.7+20001218-4
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Darren Benham
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 3 May 2000 01:32:49 +0000
Received: (qmail 20580 invoked from network); 3 May 2000 01:32:48 -0000
Received: from rm-rstar.sfu.ca (root@142.58.120.21)
by master.debian.org with SMTP; 3 May 2000 01:32:48 -0000
Received: from aldrington.ppp.cs.sfu.ca (rs3-annex1.sfu.ca [142.58.121.3])
by rm-rstar.sfu.ca (8.9.2/8.9.2/SFU-5.0H) with ESMTP id SAA25553
for <submit@bugs.debian.org>; Tue, 2 May 2000 18:29:53 -0700 (PDT)
Received: from diziet.ppp.cs.sfu.ca (diziet.ppp.cs.sfu.ca [192.42.172.2])
by aldrington.ppp.cs.sfu.ca (8.8.5/8.8.5) with ESMTP id SAA11527
for <submit@bugs.debian.org>; Tue, 2 May 2000 18:29:27 -0700 (PDT)
Received: from diziet.ppp.cs.sfu.ca (localhost [127.0.0.1])
by diziet.ppp.cs.sfu.ca (8.9.3/8.9.3/Debian 8.9.3-21) with ESMTP id SAA10031
for <submit@bugs.debian.org>; Tue, 2 May 2000 18:28:56 -0700
Message-Id: <200005030128.SAA10031@diziet.ppp.cs.sfu.ca>
To: submit@bugs.debian.org
From: "C.M. Connelly" <c@eskimo.com>
Reply-To: "C.M. Connelly" <c@eskimo.com>
Organization: Sam Hill Cabal, DS
Subject: tetex-bin: Comparison is always false errors in tftopl
and vftovp; patch enclosed
Date: Tue, 02 May 2000 18:28:55 -0700
Sender: c@eskimo.com
Package: tetex-bin
Version: 1.0.6-5
Severity: normal
When building tetex 1.0.6, tftopl and vftovp trigger ``comparison
is always false due to limited range of data type'' warnings from
the gcc 2.95 compiler, indicating a bug in the code. This bug
means that if a TFM file has more than 32510 ligkern entries,
instead of dying with an error message, tftopl and vftovp will
overflow various arrays.
The code causing these errors is identical in both files:
if nl>4*lig_size then
abort('The lig/kern program is longer than I can handle!');
(See line 482 of tftopl.web and line 644 of vftovp.web.)
As I understand it, there is no reason for multiplying lig_size by
four -- this code *should* read:
if nl>lig_size then
abort('The lig/kern program is longer than I can handle!');
Both nl and lig_size measure the size of the lig/kern program in
words. Quoting the source, nl is defined as
|@!nl|&number of words in the lig/kern table;\cr
(line 150 in tftopl.web; line 313 in vftopl.web), and the .ch
files set lig_size to be
@!lig_size=32510; {maximum length of |lig_kern| program, in words}
(line 68 in tftopl.ch; line 55 in vftopl.ch)
The following patch will fix the .ch files so that the correct C
code is generated by web2c:
--- texk/web2c/tftopl.ch.orig Sat Apr 29 02:21:12 2000
+++ texk/web2c/tftopl.ch Sat Apr 29 02:05:15 2000
@@ -136,6 +136,16 @@
:= cast_to_byte_pointer (xrealloc (tfm_file_array, 4 * lf - 1 + 1002));
@z
+% Change made by C.M. Connelly <c@eskimo.com>
+% to fix a problem resulting in ``comparison always false due to
+% limited range of data type'' errors from gcc.
+@x
+if nl>4*lig_size then
+@y
+if nl>lig_size then
+@z
+
+
% [27, 28] Change strings to C char pointers. The Pascal strings are
% indexed starting at 1, so we pad with a blank.
@x
@@ -428,3 +438,4 @@
@<Global...@> =
@!tfm_name, @!pl_name:c_string;
@z
+
--- texk/web2c/vftovp.ch.orig Sat Apr 29 02:21:12 2000
+++ texk/web2c/vftovp.ch Sat Apr 29 02:05:25 2000
@@ -123,6 +123,15 @@
end
@z
+% Change made by C.M. Connelly <c@eskimo.com>
+% to fix a problem resulting in ``comparison always false due to
+% limited range of data type'' errors from gcc.
+@x
+if nl>4*lig_size then
+@y
+if nl>lig_size then
+@z
+
% [31] Ditto for vf_abort.
@x
@d vf_abort(#)==
@@ -244,6 +253,7 @@
cur_name[r] := 0; {Append null byte since this is C.}
@z
+
@x [49] Change strings to C char pointers, so we can initialize them.
@!ASCII_04,@!ASCII_10,@!ASCII_14: packed array [1..32] of char;
{strings for output in the user's external character set}
@@ -622,3 +632,4 @@
@<Global...@> =
@!vf_name, @!tfm_name, @!vpl_name:c_string;
@z
+
I found this bug when reviewing the fail logs generated by the
PowerPC build daemon. It has been reported upstream; this patch
should allow you to fix the frozen version.
CMC
System information
==================
Debian Release: potato
Architecture: powerpc
Kernel: Linux diziet 2.2.15pre20 #2 Tue Apr 25 17:06:54 PDT 2000 ppc
Versions of packages tetex-bin depends on:
libc6 (>= 2.1.2), libpng2, libstdc++2.10, libz1, tetex-lib, xlib6g, xlib6g (>= 3.3.6), tetex-lib (>= 1.0.6), tetex-base (>= 1.0-5), ed, debianutils (>= 1.13.1)
ii libc6 2.1.3-8 GNU C Library: Shared libraries and Timezone
ii libpng2 1.0.5-1 PNG library - runtime
ii libstdc++2.10 2.95.2-7 The GNU stdc++ library
un libz1 <none> (no description available)
ii zlib1g 1.1.3-5 compression library - runtime
^^^^^^^^^^ replacement for libz1
ii tetex-lib 1.0.6-1.1 shared libkpathsea for teTeX
ii xlib6g 3.3.6-6 shared libraries required by X clients
ii xlib6g 3.3.6-6 shared libraries required by X clients
ii tetex-lib 1.0.6-1.1 shared libkpathsea for teTeX
ii tetex-base 1.0-5 basic teTeX library files
ii ed 0.2-18 The classic unix line editor
ii debianutils 1.13.3 Miscellaneous utilities specific to Debian.
---------------------------------------
Received: (at 63451-done) by bugs.debian.org; 3 Jun 2001 19:23:31 +0000
>From bunk@fs.tum.de Sun Jun 03 14:23:31 2001
Return-path: <bunk@fs.tum.de>
Received: from nilpferd.fachschaften.tu-muenchen.de [129.187.176.79]
by master.debian.org with smtp (Exim 3.12 1 (Debian))
id 156dTG-0007ZL-00; Sun, 03 Jun 2001 14:23:30 -0500
Received: (qmail 18929 invoked from network); 3 Jun 2001 19:23:27 -0000
Received: from mimas.fachschaften.tu-muenchen.de (HELO mimas) (129.187.176.26)
by nilpferd.fachschaften.tu-muenchen.de with SMTP; 3 Jun 2001 19:23:27 -0000
Date: Sun, 3 Jun 2001 21:23:20 +0200 (CEST)
From: Adrian Bunk <bunk@fs.tum.de>
X-X-Sender: <bunk@mimas.fachschaften.tu-muenchen.de>
To: <39464-done@bugs.debian.org>, <63450-done@bugs.debian.org>,
<63451-done@bugs.debian.org>, <67162-done@bugs.debian.org>,
<88397-done@bugs.debian.org>, <94457-done@bugs.debian.org>,
<94699-done@bugs.debian.org>, <94929-done@bugs.debian.org>
Subject: Fixed in tetex-bin 1.0.7+20001218-4
Message-ID: <Pine.NEB.4.33.0106032121470.13929-100000@mimas.fachschaften.tu-muenchen.de>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Delivered-To: 63451-done@bugs.debian.org
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Format: 1.7
Date: Sat, 2 Jun 2001 15:46:12 +0200
Source: tetex-bin
Binary: tetex-bin libkpathsea-dev libkpathsea3
Architecture: source i386
Version: 1.0.7+20001218-4
Distribution: unstable
Urgency: medium
Maintainer: teTeX maintainers <debian-tetex-maint@lists.debian.org>
Changed-By: Adrian Bunk <bunk@fs.tum.de>
Description:
libkpathsea-dev - kpathsea.a and include files for teTeX
libkpathsea3 - shared libkpathsea for teTeX
tetex-bin - teTeX binary files
Closes: 39464 63450 63451 67162 88397 94457 94699 94929
Changes:
tetex-bin (1.0.7+20001218-4) unstable; urgency=medium
.
* When moving xdvi in 1.0.7+20001218-1 I accidentially deleted
the move of (o)xdvi.bin to (o)xdvi.real... (closes: #94929)
* Applied a patch by C.M. Connelly <c@eskimo.com> to get texconfig
use dialog again. (closes: #94457)
* Applied a patch by LaMont Jones <lamont@smallone.fc.hp.com> to get
texk/dvipsk/afm2tfm.c compile with gcc-3.0 and updated
config.guess and config.sub. (closes: #94699)
* Applied a patch by C.M. Connelly <c@eskimo.com> to fix a problem
where Omega started the editor with an empty file.
(closes: #63450)
* Applied a patch by C.M. Connelly <c@eskimo.com> to fix a
compile warning in tftopl and vftovp. (closes: #63451)
* Call perl explicitely using #!/usr/bin/perl in the following
programs:
- e2pall
- epstopdf
- texexec
- texshow
- texutil
- thumbpdf
(closes: #67162)
* Added the following man pages written by
C.M. Connelly <c@eskimo.com>:
- e2pall.1
- fmtutil.8
- fmtutil.cnf.5
- fontinst.1
- kpsepath.1
- kpsetool.1
- kpsexpand.1
- mkfontdesc.8
- mkindex.1
- mkocp.1
- mkofm.1
- ofm2opl.1
- opl2ofm.1
- otp2ocp.1
- outocp.1
- ovf2ovp.1
- ovp2ovf.1
- pslatex.1
- rubibtex.1
- rumakeindex.1
- texdoc.1
- texexec.1
- texi2pdf.1
- texlinks.8
- texshow.1
- texutil.1
- thumbpdf.1
- ttf2afm.1
(closes: #39464)
* Made the build dependency on debhelper versioned (>= 3.0.6)
because we use dh_installman now.
* Made a small correction to xdvi.1. (closes: #88397)
Files:
072f39905b73bb721e0282bbda56021d 815 tex standard tetex-bin_1.0.7+20001218-4.dsc
a5a1c7b7601a12655ce201871cf6be9f 52014 tex standard tetex-bin_1.0.7+20001218-4.diff.gz
541b686ac8c86208ed0666f9828e3ec0 2546110 tex standard tetex-bin_1.0.7+20001218-4_i386.deb
71e94a21594bc668c9a0f5ea233785e4 34910 libs standard libkpathsea3_1.0.7+20001218-4_i386.deb
78275dc88bce9a1acaa869ced364956f 63310 devel optional libkpathsea-dev_1.0.7+20001218-4_i386.deb
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.0.6 (GNU/Linux)
Comment: For info see http://www.gnupg.org
iD8DBQE7GnoemfzqmE8StAARAqDZAKCJ95I0k0K6g/SMUWy5ajzyOTahegCeJf4Y
R+l3hE6+6YSMbjaZKbDnHcg=
=6p+n
-----END PGP SIGNATURE-----
Reply to: