[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

linux FTBFS on sh4



linux is currently failing to build on sh4:
http://buildd.debian-ports.org/status/fetch.php?pkg=linux&arch=sh4&ver=3.8.11-1&stamp=1367971740

This seems to be because the aoe driver uses virt_addr_valid(), which on
sh is a macro that uses variables that are not exported to modules.  I
think the bug is in the sh port, not the driver.  If someone could
verify that the attached patch fixes this then I'll be happy to apply it
and submit it upstream.

Ben.

-- 
Ben Hutchings
I'm not a reverse psychological virus.  Please don't copy me into your sig.
From: Ben Hutchings <ben@decadent.org.uk>
Subject: sh: mm: Export {min,max}_low_pfn
Date: Mon, 10 Jun 2013 02:03:36 +0100

The pfn_valid() macro uses the {min,max}_low_pfn variables, so they
must be exported in order that pfn_valid() or virt_addr_valid() can
be used in modules.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Cc: stable@vger.kernel.org
---
--- a/arch/sh/mm/init.c
+++ b/arch/sh/mm/init.c
@@ -395,6 +395,10 @@ void __init paging_init(void)
 	free_area_init_nodes(max_zone_pfns);
 }
 
+/* pfn_valid() needs these */
+EXPORT_SYMBOL(min_low_pfn);
+EXPORT_SYMBOL(max_low_pfn);
+
 /*
  * Early initialization for any I/O MMUs we might have.
  */

Attachment: signature.asc
Description: This is a digitally signed message part


Reply to: