[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#1118288: openssh-client: ssh-agent does not handle paths with spaces



Package: openssh-client
Version: 1:10.2p1-1
Severity: normal

ssh-agent does not gracefully handle paths with spaces for the agent
socket.  This was less of a problem when it used $TMPDIR, but now that
it uses $HOME, this breaks things for the Git testsuite[0], which sets
$HOME to a path with spaces (to test that Git code is robust in that
case).

Here's an example to demonstrate:

----
#!/bin/sh -ex

tmpdir=$(mktemp -d)

mkdir "$tmpdir/path with spaces"
cd "$tmpdir/path with spaces"
export HOME="$PWD"

mkdir .ssh

eval $(ssh-agent)
----

ssh-agent, as well as all other parts of OpenSSH, should be robust with
arbitrary Unix paths to the extent possible (for instance, with the
shell, it might not be possible to handle trailing newlines, but
everything else should work).

[0] Thread at https://lore.kernel.org/git/xmqqbjm51l3a.fsf@gitster.g/T/#m77d1c02f0c018e9c71cf6e0cb699811abf0c39ce

-- System Information:
Debian Release: forky/sid
  APT prefers unstable
  APT policy: (500, 'unstable'), (1, 'experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 6.16.11+deb14-amd64 (SMP w/24 CPU threads; PREEMPT)
Locale: LANG=en_CA.UTF-8, LC_CTYPE=en_CA.UTF-8 (charmap=UTF-8), LANGUAGE not set
Shell: /bin/sh linked to /usr/bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages openssh-client depends on:
ii  adduser              3.153
ii  init-system-helpers  1.69
ii  libc6                2.41-12
ii  libedit2             3.1-20250104-1
ii  libfido2-1           1.16.0-2
ii  libgssapi-krb5-2     1.21.3-5
ii  libselinux1          3.8.1-1
ii  libssl3t64           3.5.4-1
ii  passwd               1:4.18.0-1
ii  zlib1g               1:1.3.dfsg+really1.3.1-1+b1

Versions of packages openssh-client recommends:
ii  xauth  1:1.1.2-1.1

Versions of packages openssh-client suggests:
pn  keychain      <none>
pn  libpam-ssh    <none>
pn  monkeysphere  <none>
pn  ssh-askpass   <none>

-- no debconf information

-- 
brian m. carlson (they/them)
Toronto, Ontario, CA

Attachment: signature.asc
Description: PGP signature


Reply to: