[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#961311: marked as done (ssh-agent.service: cannot work without x11-common installed)

Your message dated Tue, 15 Apr 2025 13:34:34 +0000
with message-id <E1u4gQs-008GaI-MB@fasolo.debian.org>
and subject line Bug#961311: fixed in openssh 1:10.0p1-2
has caused the Debian Bug report #961311,
regarding ssh-agent.service: cannot work without x11-common installed
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
961311: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=961311
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message --- 
Package: openssh-client
Version: 1:8.2p1-4
Severity: normal
File: /usr/lib/systemd/user/ssh-agent.service
Usertags: wayland

On pure-Wayland systems, the ssh-agent.service is not going to be able
to start because x11-common won't nessecarily be installed. I think
either the ConditionPathExists should get dropped and the script should
check if the Xsession.options file exists before using it, when it
doesn't exist people using Wayland without x11-common installed can just use `systemctl --user mask/enable/disable` to manage the service.

PS: shellcheck reports some issues for the agent-launch script.

$ systemctl --user cat ssh-agent.service 
# /usr/lib/systemd/user/ssh-agent.service
[Unit]
Description=OpenSSH Agent
Documentation=man:ssh-agent(1)
Before=graphical-session-pre.target
ConditionPathExists=/etc/X11/Xsession.options
Wants=dbus.socket
After=dbus.socket

[Service]
ExecStart=/usr/lib/openssh/agent-launch start
ExecStopPost=/usr/lib/openssh/agent-launch stop

$ dpkg -S /etc/X11/Xsession.options
x11-common: /etc/X11/Xsession.options

$ grep -A4 /etc/X11/Xsession.options /usr/lib/openssh/agent-launch
    if [ -z "$SSH_AUTH_SOCK" ] && grep -s -q '^use-ssh-agent$' /etc/X11/Xsession.options; then
        S="$XDG_RUNTIME_DIR/openssh_agent"
        dbus-update-activation-environment --verbose --systemd SSH_AUTH_SOCK=$S SSH_AGENT_LAUNCHER=openssh
        exec ssh-agent -D -a $S
    fi

$ shellcheck /usr/lib/openssh/agent-launch 

In /usr/lib/openssh/agent-launch line 6:
    echo 'This needs $XDG_RUNTIME_DIR to be set' >&2
         ^-- SC2016: Expressions don't expand in single quotes, use double quotes for that.


In /usr/lib/openssh/agent-launch line 13:
        dbus-update-activation-environment --verbose --systemd SSH_AUTH_SOCK=$S SSH_AGENT_LAUNCHER=openssh
                                                                             ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean: 
        dbus-update-activation-environment --verbose --systemd SSH_AUTH_SOCK="$S" SSH_AGENT_LAUNCHER=openssh


In /usr/lib/openssh/agent-launch line 14:
        exec ssh-agent -D -a $S
                             ^-- SC2086: Double quote to prevent globbing and word splitting.

Did you mean: 
        exec ssh-agent -D -a "$S"

For more information:
  https://www.shellcheck.net/wiki/SC2016 -- Expressions don't expand in singl...
  https://www.shellcheck.net/wiki/SC2086 -- Double quote to prevent globbing ...


-- System Information:
Debian Release: bullseye/sid
  APT prefers testing-debug
  APT policy: (900, 'testing-debug'), (900, 'testing'), (800, 'unstable-debug'), (800, 'unstable'), (790, 'buildd-unstable'), (700, 'experimental-debug'), (700, 'experimental'), (690, 'buildd-experimental')
Architecture: amd64 (x86_64)

Kernel: Linux 5.6.0-1-amd64 (SMP w/4 CPU cores)
Kernel taint flags: TAINT_FIRMWARE_WORKAROUND
Locale: LANG=en_AU.utf8, LC_CTYPE=en_AU.utf8 (charmap=UTF-8), LANGUAGE=en_AU:en (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)
LSM: AppArmor: enabled

Versions of packages openssh-client depends on:
ii  adduser           3.118
ii  dpkg              1.19.7
ii  libc6             2.30-8
ii  libedit2          3.1-20191231-1
ii  libfido2-1        1.4.0-1
ii  libgssapi-krb5-2  1.17-7
ii  libselinux1       3.0-1+b3
ii  libssl1.1         1.1.1g-1
ii  passwd            1:4.8.1-1
ii  zlib1g            1:1.2.11.dfsg-2

Versions of packages openssh-client recommends:
ii  xauth  1:1.0.10-1

Versions of packages openssh-client suggests:
pn  keychain                         <none>
pn  libpam-ssh                       <none>
ii  monkeysphere                     0.43-3
ii  ssh-askpass-gnome [ssh-askpass]  1:8.2p1-4

-- no debconf information

-- 
bye,
pabs

https://wiki.debian.org/PaulWise

Attachment: signature.asc
Description: This is a digitally signed message part


--- End Message ---
--- Begin Message --- 
Source: openssh
Source-Version: 1:10.0p1-2
Done: Colin Watson <cjwatson@debian.org>

We believe that the bug you reported is fixed in the latest version of
openssh, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 961311@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Colin Watson <cjwatson@debian.org> (supplier of updated openssh package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

Format: 1.8
Date: Tue, 15 Apr 2025 14:19:35 +0100
Source: openssh
Architecture: source
Version: 1:10.0p1-2
Distribution: unstable
Urgency: medium
Maintainer: Debian OpenSSH Maintainers <debian-ssh@lists.debian.org>
Changed-By: Colin Watson <cjwatson@debian.org>
Closes: 961311 1039919 1072184 1095686 1103037
Changes:
 openssh (1:10.0p1-2) unstable; urgency=medium
 .
   [ Colin Watson ]
   * Disable --with-linux-memlock-onfault on riscv64.
   * Build with wtmpdb (see #1102643).
   * Stop writing /var/log/btmp, since nothing reads it any more (closes:
     #1072184).
   * Restore some rdomain references in sshd_config(5) where they're
     supported on Linux, referring to ip-vrf(8) (closes: #1095686).
 .
   [ Daniel Kahn Gillmor ]
   * Improve systemd user service socket activation (closes: #961311,
     #1039919, #1103037).
 .
   [ Luca Boccassi ]
   * Switch from adduser to sysusers.d.
   * Add sshd-keygen service.
Checksums-Sha1:
 f48045f3e303d1afc0cbe6ec5ebcaf6fb5c0dfbe 3500 openssh_10.0p1-2.dsc
 120a3fe008e5446deb087d17f448d7a040462fcf 198240 openssh_10.0p1-2.debian.tar.xz
Checksums-Sha256:
 e67c945e39cefe5d38f1dbd6d122ca2b17193e65788bf48c4d36f7c5b5f1c57c 3500 openssh_10.0p1-2.dsc
 9d08fe1de56fe63dbf1c17a4ecc79f3584b9f0d9690f4d709b0d3e3a812ef210 198240 openssh_10.0p1-2.debian.tar.xz
Files:
 3a158dd3d2cb1789012ad7371ae010b7 3500 net standard openssh_10.0p1-2.dsc
 b489588918c744d5ceb5e238a7825f85 198240 net standard openssh_10.0p1-2.debian.tar.xz

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEErApP8SYRtvzPAcEROTWH2X2GUAsFAmf+XRsACgkQOTWH2X2G
UAs3XRAAh+32VBJwqC7rRdaE1RB+vbG13H7AVSbvlgOpfX1D28bMzwyEpOZ/+hOf
N14Y3Ud720t3XU24caXxujeDp9ro8qd6v4AVAlARXQ7071SmZPcI3k2skW4beSwU
ZTa6kbsR8yU+IUrmEAKgkQxQG0REy95Th0UF7iTeA0RUV/brzKqeusyxD7Kuk2/C
FgHlcr6B1PZSEj1UZlpi5T+qAfEgZYfrkBZ4XYx8PwI6MC23cjYL+TpitNu1DZsD
0PP6Z+OIbX9d2UE1f9qbvp5ZXWP87L1haYneiM+wZzEjRf7iH09Cz22MTDGu5WFb
F0JcrCubjvfVcVPNA7Iw8EDePOIHyc944FLxcuCZe3EzEG3X8aZWoPzk7ryq08a6
dT8vvgHWD4E+yLEowHD/xzE4MvRdO5YEZp5qD9K3fH6F+CiviQSvG4Ear8o9941x
tVGTaScogN7GgeO6ECwB1OpheQSxx7y0aPqSyYDOc1uEGOuMR1M5qG4gHqrJbU+h
XKl3+G1gfXVdSDF1COpgg4YVVEMYSOGtA97TD4TXGRbJkASStOkulm+84HFmZPf2
TA4jERPjczjpaqawF9I/N1eZkwOS8gVsqEvN7dhn9jTiulmR7sCox6mflvRcWeJg
Uh5kcsOkG5vIzsonJEDfElxQDVT7QRqqmGRRpwhPcveAFgtT7c8=
=HCF+
-----END PGP SIGNATURE-----

Attachment: pgpJGFVJY66Pc.pgp
Description: PGP signature


--- End Message ---
Reply to: