[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#893934: openssh-client: Potentially unintended dependency on libbsd



Control: reassign -1 libedit-dev 3.1-20170329-1

On Sat, Mar 24, 2018 at 02:37:57AM +0100, Guillem Jover wrote:
> I just noticed that the latest version of this package depends on
> libbsd0, which at first thought it was nice given my previous bug
> request :), but then realized it was probably unintended when I
> checked the actual sources. Here's the reasons why:
> 
>   * Build-Depends on libedit-dev, which pulls in libbsd-dev.
>   * configure.ac uses AC_CHECK_LIB instead of AC_SEARCH_LIBS to
>     check for daemon(), which detects daemon() from glibc and
>     concludes that libsd is needed.

Nope.  The check you mention is in the false branch of an
AC_CHECK_FUNC([daemon], ...), so isn't run because we detect glibc's
version first.

The actual reason is:

  $ pkg-config --libs libedit
  -ledit -lncurses -lbsd

Maybe -lbsd should be moved to Libs.private?  But I don't know the
libedit interface in detail, and in any case this is up to the libedit
maintainers, so reassigning.

Thanks,

-- 
Colin Watson                                       [cjwatson@debian.org]


Reply to: