Bug#797964: still happens

[Russell Coker <russell@coker.com.au>]

On Mon, 4 Apr 2016 07:33:18 PM Russell Coker wrote:
> This still happens exactly as reported in version 1:7.2p2-2.

I've attached a 1 line patch to fix this.  Here is the output of using ssh to 
transfer 1MB of /dev/urandom from a remote system to a local system with the 
version in Unstable:

debug1: compress outgoing: raw data 847, compressed 464, factor 0.55
debug1: compress incoming: raw data 464, compressed 847, factor 1.83

Here is the output when transfering it with the patched version:

debug1: compress outgoing: raw data 847, compressed 464, factor 0.55
debug1: compress incoming: raw data 10488794, compressed 10492323, factor 1.00


Here is the output when transfering the 1MB of random data the other way:

debug1: compress outgoing: raw data 10488830, compressed 10492359, factor 1.00
debug1: compress incoming: raw data 786, compressed 401, factor 0.51

I am totally confident that this patch is good enough to include.  The error 
was a copy/paste error in the initial code, this is what the original author 
intended.

-- 
My Main Blog         http://etbe.coker.com.au/
My Documents Blog    http://doc.coker.com.au/

--- openssh-7.2p2.orig/packet.c
+++ openssh-7.2p2/packet.c
@@ -525,7 +525,7 @@ ssh_packet_close(struct ssh *ssh)
 				deflateEnd(stream);
 		}
 		if (state->compression_in_started) {
-			z_streamp stream = &state->compression_out_stream;
+			z_streamp stream = &state->compression_in_stream;
 			debug("compress incoming: "
 			    "raw data %llu, compressed %llu, factor %.2f",
 			    (unsigned long long)stream->total_out,