[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#757059: marked as done (Dynamic part of MOTD out of date)



Your message dated Tue, 05 Aug 2014 09:37:08 +0000
with message-id <E1XEbB6-0007DO-4e@franck.debian.org>
and subject line Bug#757059: fixed in openssh 1:6.6p1-7
has caused the Debian Bug report #757059,
regarding Dynamic part of MOTD out of date
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@bugs.debian.org
immediately.)


-- 
757059: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=757059
Debian Bug Tracking System
Contact owner@bugs.debian.org with problems
--- Begin Message ---
Package: openssh-server
Version: 1:6.6p1-6
Severity: normal
Tags: patch

Dear Maintainer,

Customizing a dynamic MOTD in /etc/update-motd.d does not work as expected.  As a simple testcase, create a script there that simply runs "date".  Upon login, the date of the *previous* login, not the current date, will get printed.

The problem is in /etc/pam.d/sshd (or debian/openssh-server.sshd.pam.in in the source).  The flag "noupdate" ought to be passed to the *second* call to pam_motd.so, not the *first* as is currently done.

The buggy behavior happens as follows, tracing through the pam file:
1. session    optional     pam_motd.so  motd=/run/motd.dynamic noupdate
  a. This will not change /run/motd.dynamic (due to the "noupdate" flag)
  b. This will will then cat the unchanged /run/motd.dynamic (the file specified by the motd= flag)
2. session    optional     pam_motd.so # [1]
  a. This will change /run/motd.dynamic (this path is hardcoded into PAM).
  b. This will cat /etc/motd (the default file hardcoded into the source)

The changed /run/motd.dynamic is NOT displayed in step 2, but it will get displayed
on the next login in step 1.a.

The attached patch fixes the problem:

This system information below as collected by reportbug is inaccurate; the bug report above reflects the head of the Debian source repository. git://anonscm.debian.org/pkg-ssh/openssh.git

-- System Information:
Debian Release: 7.6
  APT prefers stable
  APT policy: (990, 'stable'), (500, 'stable-updates')
Architecture: amd64 (x86_64)
Foreign Architectures: i386

Kernel: Linux 3.2.0-4-amd64 (SMP w/8 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages openssh-server depends on:
ii  adduser                3.113+nmu3
ii  debconf [debconf-2.0]  1.5.49
ii  dpkg                   1.16.15
ii  libc6                  2.13-38+deb7u3
ii  libcomerr2             1.42.5-1.1
ii  libgssapi-krb5-2       1.10.1+dfsg-5+deb7u1
ii  libkrb5-3              1.10.1+dfsg-5+deb7u1
ii  libpam-modules         1.1.3-7.1
ii  libpam-runtime         1.1.3-7.1
ii  libpam0g               1.1.3-7.1
ii  libselinux1            2.1.9-5
ii  libssl1.0.0            1.0.1e-2+deb7u11
ii  libwrap0               7.6.q-24
ii  lsb-base               4.1+Debian8+deb7u1
ii  openssh-client         1:6.0p1-4+deb7u2
ii  procps                 1:3.3.3-3
ii  zlib1g                 1:1.2.7.dfsg-13

Versions of packages openssh-server recommends:
ii  ncurses-term             5.9-10
ii  openssh-blacklist        0.4.1+nmu1
ii  openssh-blacklist-extra  0.4.1+nmu1
ii  xauth                    1:1.0.7-1

Versions of packages openssh-server suggests:
pn  molly-guard   <none>
pn  monkeysphere  <none>
pn  rssh          <none>
pn  ssh-askpass   <none>
pn  ufw           <none>

-- debconf-show failed
--- openssh/debian/openssh-server.sshd.pam.in	2014-08-04 19:48:08.159979937 -0400
+++ openssh/debian/openssh-server.sshd.pam.in	2014-08-04 19:48:08.159979937 -0400
@@ -30,8 +30,8 @@
 # Print the message of the day upon successful login.
 # This includes a dynamically generated part from /run/motd.dynamic
 # and a static (admin-editable) part from /etc/motd.
-session    optional     pam_motd.so  motd=/run/motd.dynamic noupdate
-session    optional     pam_motd.so # [1]
+session    optional     pam_motd.so  motd=/run/motd.dynamic
+session    optional     pam_motd.so noupdate
 
 # Print the status of the user's mailbox upon successful login.
 session    optional     pam_mail.so standard noenv # [1]

--- End Message ---
--- Begin Message ---
Source: openssh
Source-Version: 1:6.6p1-7

We believe that the bug you reported is fixed in the latest version of
openssh, which is due to be installed in the Debian FTP archive.

A summary of the changes between this version and the previous one is
attached.

Thank you for reporting the bug, which will now be closed.  If you
have further comments please address them to 757059@bugs.debian.org,
and the maintainer will reopen the bug report if appropriate.

Debian distribution maintenance software
pp.
Colin Watson <cjwatson@debian.org> (supplier of updated openssh package)

(This message was generated automatically at their request; if you
believe that there is a problem with it please contact the archive
administrators by mailing ftpmaster@ftp-master.debian.org)


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Format: 1.8
Date: Tue, 05 Aug 2014 09:10:04 +0100
Source: openssh
Binary: openssh-client openssh-server openssh-sftp-server ssh ssh-krb5 ssh-askpass-gnome openssh-client-udeb openssh-server-udeb
Architecture: source i386 all
Version: 1:6.6p1-7
Distribution: unstable
Urgency: medium
Maintainer: Debian OpenSSH Maintainers <debian-ssh@lists.debian.org>
Changed-By: Colin Watson <cjwatson@debian.org>
Description:
 openssh-client - secure shell (SSH) client, for secure access to remote machines
 openssh-client-udeb - secure shell client for the Debian installer (udeb)
 openssh-server - secure shell (SSH) server, for secure access from remote machines
 openssh-server-udeb - secure shell server for the Debian installer (udeb)
 openssh-sftp-server - secure shell (SSH) sftp server module, for SFTP access from remot
 ssh        - secure shell client and server (metapackage)
 ssh-askpass-gnome - interactive X program to prompt users for a passphrase for ssh-ad
 ssh-krb5   - secure shell client and server (transitional package)
Closes: 756757 757059
Changes:
 openssh (1:6.6p1-7) unstable; urgency=medium
 .
   * Make sure that DEB_HOST_ARCH is set, even when invoking debian/rules
     directly.
   * Use dh-exec to simplify override_dh_install target.
   * Remove several unnecessary entries in debian/*.dirs.
   * Pass noupdate to the second call to pam_motd, not the first (thanks, Ken
     T Takusagawa; closes: #757059).
   * Debconf translations:
     - Turkish (thanks, Mert Dirik; closes: #756757).
Checksums-Sha1:
 69483d0da029e94099b5f5f231216d41cf675b87 2710 openssh_6.6p1-7.dsc
 50aab7cbf4d11eb7c00d3ab08f3340ca66d37aa1 145224 openssh_6.6p1-7.debian.tar.xz
 39c9b47c73f6d21b9a1b290a8bdd5d4d91070c31 712764 openssh-client_6.6p1-7_i386.deb
 9decd6b937ab473766c03bc6eb9478b4b50dde9d 358102 openssh-server_6.6p1-7_i386.deb
 a211ef8998dd2dd6c629aca56ecc90e476ab6b86 38222 openssh-sftp-server_6.6p1-7_i386.deb
 96f2feddb27540f0c25dae6e31bebbea09633939 1114 ssh_6.6p1-7_all.deb
 96bba9b76726a128b6462e55f73971788682c670 105444 ssh-krb5_6.6p1-7_all.deb
 9c9c9a351391fe2ef65b58e94cb4f2f4b1453641 113280 ssh-askpass-gnome_6.6p1-7_i386.deb
 1acf414a976f5eae928a782698110f6c6eb24daa 256932 openssh-client-udeb_6.6p1-7_i386.udeb
 0979f3425a4825de2e0023daf117658fae022ec5 287166 openssh-server-udeb_6.6p1-7_i386.udeb
Checksums-Sha256:
 f34c3e5f62cc1dd1c482647f83fc37b830e2a9cf3e1efa42297615e8f5b9b380 2710 openssh_6.6p1-7.dsc
 fc099bd4a4a2b8ac961770c3b5eab11b1f119625699e0f0a1e5275edd6f9e74a 145224 openssh_6.6p1-7.debian.tar.xz
 44595135d81c49ef634910e04357d1e97aec282988a42a416f6c1059acd8f22a 712764 openssh-client_6.6p1-7_i386.deb
 f3c06c82025717791a9899a0c0ac169b366e06b42335316f3e3bcebf8b0d16fb 358102 openssh-server_6.6p1-7_i386.deb
 14852f5c2ba4a909d95e93f6ae4fb6ff81cc7e39a7bfdaa65d840a99fe628a67 38222 openssh-sftp-server_6.6p1-7_i386.deb
 dc226ed1d71cbe11a140ce4f565c3b661a38746db156d12d483d32d012d2aa55 1114 ssh_6.6p1-7_all.deb
 d7e12faa159e3283b59ad4b78fe8a89162ddb39033c56979cf9bbfe5edc75f47 105444 ssh-krb5_6.6p1-7_all.deb
 dd6063431794f4625c374b1dd5ee78dea3f9ee45b2c1e9e37e4a99a20920ac4a 113280 ssh-askpass-gnome_6.6p1-7_i386.deb
 902725b4f2781cc26893328624ba87fa50312754352d788071637c5f34e97dff 256932 openssh-client-udeb_6.6p1-7_i386.udeb
 8dd14a99307e35c5937c1a9dc05b7b208f25aaa924f0f9813ca5465f6eee6bac 287166 openssh-server-udeb_6.6p1-7_i386.udeb
Files:
 7c4306489d86772cbb293d76779529cc 712764 net standard openssh-client_6.6p1-7_i386.deb
 56125dd75023f7ff23b97062a7e6ebf5 358102 net optional openssh-server_6.6p1-7_i386.deb
 e3090efd4178305dbbb7cbd809cea5b8 38222 net optional openssh-sftp-server_6.6p1-7_i386.deb
 5fa1011abc64fc8e144056e9959937ff 1114 net extra ssh_6.6p1-7_all.deb
 7bc92ba613a36d9ebcfe247cf69d6e75 105444 oldlibs extra ssh-krb5_6.6p1-7_all.deb
 5d42981e172788d81927835ff11541de 113280 gnome optional ssh-askpass-gnome_6.6p1-7_i386.deb
 97e8468d477fbde7cbcaf8511ac0d9f5 256932 debian-installer optional openssh-client-udeb_6.6p1-7_i386.udeb
 5d794803caa463a4fb9a5aca4e4db50b 287166 debian-installer optional openssh-server-udeb_6.6p1-7_i386.udeb
 dd987d5082a59ddaf759ce2646f86255 2710 net standard openssh_6.6p1-7.dsc
 8ecb5e7243f0b0b1c2319f410a25e07c 145224 net standard openssh_6.6p1-7.debian.tar.xz
Package-Type: udeb

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1
Comment: Colin Watson <cjwatson@debian.org> -- Debian developer

iQIVAwUBU+CU6Dk1h9l9hlALAQhl9g//SO7PgKWwz3BSam92qb/llueQMYPgt9um
qog1J6NgBtFyPLenDwWKYZAVMz1NeuBLxI+oZnKXtrpWEGov6wdh/PGWkxsPKvAq
Uf82Of7cT92d/MPaTb4uqs8vOlIc0dkappzUGkZJhqBtD7gFbx6qGh/b6gxKQbnu
tdPQxr8ighGSqAxq2/DexZkZVMvSRpoRW/ziyUFq9CGXwi9XAdj89YuATAfkxBhI
BvDeV3eCYyc4CCsv4T6ZM2uLkYAWhPV6/lk405/nICBhhGT0KGpJ6P6YcUhi4m0q
nrVCROB9KnCSUcIMYtFULHElXEdOwU16baLrBnsDsW8C7FnhUv1oM28nPYiy3lSi
+kwOKO+6EcJ7adjakdlM4HzWHz0akw8grwyJJ2+6puJ2ETWaJDHOuM8m8A85h4Z6
5mf3pPjHTArn04Ir373EFPkNXLip+NVpKtZnv+ysPBa4qf+Mc4X5FlsX8wmRRlmS
ajgXVx/eBe9D9cVtJ6Ig50LU/F20OZGrYbzQaRjvcx86EXM2ArivAAm2wUwtK6rB
3mFo450Y+Dzm0TEhI/2Al+CuYBxQR8LKBh9Dod8lOFJGBzc759YNJ8JOFFqWp1xl
ktQregvDXSlWicGpBRkFtKyGrvDwMYkGHIDlRkiUpHHqVdHgAIzcrTS7hxB4AFqz
x/uOWfge+Ts=
=baPS
-----END PGP SIGNATURE-----

--- End Message ---

Reply to: