Bug#754842: [openssh-client] weird output from ssh-add -D when used with ssh-agent-filter

[Timo Weingärtner <timo@tiwe.de>]

Package: openssh-client
Version: 1:6.6p1-6
Severity: minor

> $ SSH_ASKPASS=true afssh -A -- localhost ssh-add -D | cat
> SSH_AGENT_FAILURE
> All identities removed.

See the relevant part of an strace of ssh-add -D, annotated with the names
for the message numbers:

> connect(3, {sa_family=AF_FILE, path="/tmp/ssh-H8TZMh3Lsb/agent.5962"}, 110) = 0
> write(3, "\0\0\0\1", 4)                 = 4
> write(3, "\t", 1)                       = 1
SSH_AGENTC_REMOVE_ALL_RSA_IDENTITIES
> read(3, "\0\0\0\1", 4)                  = 4
> read(3, "\6", 1)                        = 1
SSH_AGENT_SUCCESS
> write(3, "\0\0\0\1", 4)                 = 4
> write(3, "\23", 1)                      = 1
SSH2_AGENTC_REMOVE_ALL_IDENTITIES
> read(3, "\0\0\0\1", 4)                  = 4
> read(3, "\5", 1)                        = 1
SSH_AGENT_FAILURE
> write(2, "SSH_AGENT_FAILURE\r\n", 19)   = 19
> write(2, "All identities removed.\n", 24) = 24
> close(3)                                = 0
> exit_group(0)                           = ?

The message "All identities removed." is wrong here, ssh-agent-filter denied
the request and the SSH2 identities are still in the ssh-agent.


Greetings
Timo

Attachment: signature.asc
Description: This is a digitally signed message part.