[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: [Pkg-systemd-maintainers] systemd support in openssh-server



On Wed, Feb 12, 2014 at 08:23:56AM +0100, Michael Biebl wrote:
> Instead of moving the stop into preinst though, my suggestion would be
> to remove the check "! systemctl --quiet is-active ssh" completely.
> 
> This obviously has the downside, that sshd could not actually be running
> and in case there is a stale pid file, we might end up killing a wrong
> process. To avoid that, I'd probably use and additional --exec test like
> 
> start-stop-daemon --stop --quiet --oknodo --pidfile /var/run/sshd.pid
> --exec /usr/sbin/sshd || true

Yes, this seems right and it behaves sensibly in my tests.  I've
committed it for 1:6.5p1-3.  Thanks!

-- 
Colin Watson                                       [cjwatson@debian.org]


Reply to: