[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#715194: openssh-server: ship systemd unit files



On Mon, Feb 10, 2014 at 06:22:14PM +0100, Sven Joachim wrote:
> On 2014-02-10 15:44 +0100, Colin Watson wrote:
> > The only other significant error I see in your patch is that we really
> > should not be going back to creating /var/run/sshd in the postinst; that
> > doesn't necessarily persist across boots and doing anything with it in
> > maintainer scripts is inappropriate.  But that's easy to rip out again,
> > since you also added tmpfiles.d support.
> 
> AFAICS tmpfiles.d files are processed _only_ at boot time, so there's
> the problem of creating the directory when openssh-server is installed
> for the first time.  While it would be nice to have
> "systemd-tmpfiles --create sshd.conf" automagically run if systemd is
> PID 1, this does not currently happen I'm afraid.

Oh.  In that case how about we do this instead, with a comment
explaining why:

  ExecStartPre=/bin/mkdir -p -m0755 /var/run/sshd

I'm just worried that doing this in the postinst will mask other bugs.

-- 
Colin Watson                                       [cjwatson@debian.org]


Reply to: