[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#711215: openssh-client: ssh-copy-id improved



On Wed, Jun 05, 2013 at 05:31:15PM +0200, Cristian Ionescu-Idbohrn wrote:
> From 8e9d55e6c980a455c349afcffde1c1ac104a778b Mon Sep 17 00:00:00 2001
> From: Cristian Ionescu-Idbohrn <cristian.ionescu-idbohrn@axis.com>
> Date: Wed, 5 Jun 2013 16:59:30 +0200
> Subject: [PATCH 1/4] Cleanup end-of-line whitespace damage.

I'd recommend just dropping this, but if you really want to push it then
please send it upstream; I'm not going to carry a patch for this sort of
thing.

> From 083e07cd691c4de39c34d9e633cd9ba89b425219 Mon Sep 17 00:00:00 2001
> From: Cristian Ionescu-Idbohrn <cristian.ionescu-idbohrn@axis.com>
> Date: Wed, 5 Jun 2013 17:01:09 +0200
> Subject: [PATCH 2/4] Remove bashism.

This is #711162, already fixed (more robustly, if anything) for my next
upload.

> From 931f89f491122b69f56d806fb96cda127c748407 Mon Sep 17 00:00:00 2001
> From: Cristian Ionescu-Idbohrn <cristian.ionescu-idbohrn@axis.com>
> Date: Wed, 5 Jun 2013 17:06:13 +0200
> Subject: [PATCH 3/4] Correct some "parameter not set" errors revealed by `set
>  -u'.

We don't use 'set -u' and I don't think it's necessary to make all
scripts work with it.  However, if you must, could you please forward
this upstream?  https://bugzilla.mindrot.org/

> From 22612bd1367b064b3dda144226bb26bfb1ba94b0 Mon Sep 17 00:00:00 2001
> From: Cristian Ionescu-Idbohrn <cristian.ionescu-idbohrn@axis.com>
> Date: Wed, 5 Jun 2013 17:10:46 +0200
> Subject: [PATCH 4/4] Workaround dash bug revealed by running with `set -e'.

It might be clearer to just use 'set +e' inside this subshell, perhaps.
But if you think that's wrong then perhaps you could clean up the tab
damage in this and send it upstream separately?

Thanks,

-- 
Colin Watson                                       [cjwatson@debian.org]


Reply to: