Bug#606922: closed by Colin Watson <cjwatson@debian.org> (Re: Bug#606922: jpake not enabled in sid)
On Fri, Dec 17, 2010 at 02:14:23AM -0500, Michael Gilbert wrote:
> On Fri, Dec 17, 2010 at 12:53 AM, Russ Allbery wrote:
> > Michael Gilbert <michael.s.gilbert@gmail.com> writes:
> >> I apologize ahead of time for the bts ping pong, but according to the
> >> build log (which is where I checked for my original bug report) jpake
> >> is indeed built.
> >
> >> $ debuild | grep jpake
> >
> > jpake.c is run through the compiler, but the entire file is stubbed out if
> > the preprocessor define JPAKE is not enabled, and I don't see anything in
> > the build system that would set this. From the upstream ChangeLog (note
> > the last bit):
>
> This appears to be true, but I would be more comfortable if the object
> code were explicitly not built and thus 100% known to not be used or
> available in any of the libs.
>
> Attached is a patch that does that.
No, I would really rather not diverge further from upstream for a patch
that has no effect on the generated object code. Please appeal to
upstream (bugzilla.mindrot.org) if you want this changed; personally I
think it's probably not worth the effort since it seems likely that they
intend to enable this eventually once it's fixed up, so it would just be
unnecessary churn in the meantime.
I am 100% certain that this code is not present in the generated object
code, and don't need further assurance of that:
$ nm -D /usr/bin/ssh /usr/sbin/sshd | grep jpake
$
Regards,
--
Colin Watson [cjwatson@debian.org]
Reply to: