Bug#607267: /usr/bin/scp: fails to notice close() errors

[Michal Suchanek <michal.suchanek@ruk.cuni.cz>]

Package: openssh-client
Version: 1:5.5p1-5+b1
Severity: grave
File: /usr/bin/scp
Justification: causes non-serious data loss


scp fails to notice close() errors.

To reproduce:

- mount a 10M tmpfs

- export it through samba

- mount the share through cifs

- take a 12M file (eg dd from /dev/zero)

When you copy the file to the samba share no error is reported.

The tail of the file is silently lost.

$ scp /scratch/junk . ; echo $?
0
$ rm junk
$ cat /scratch/junk |  gzip -c > junk

gzip: stdout: No space left on device
$ rm junk
$ cat /scratch/junk |  gzip -c | split -d -a 3 -b 6M - junk.gz. ; echo $?
split: junk.gz.001: No space left on device
1





-- System Information:
Debian Release: squeeze/sid
  APT prefers testing
  APT policy: (910, 'testing'), (900, 'stable'), (500, 'unstable'), (200, 'experimental'), (111, 'oldstable')
Architecture: amd64 (x86_64)

Kernel: Linux 2.6.36-rc6-r600fence-smbinit-amd64 (SMP w/4 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8) (ignored: LC_ALL set to en_US.UTF-8)
Shell: /bin/sh linked to /bin/bash

Versions of packages openssh-client depends on:
ii  adduser              3.112+nmu2          add and remove users and groups
ii  debconf [debconf-2.0 1.5.36              Debian configuration management sy
ii  dpkg                 1.15.8.5            Debian package management system
ii  libc6                2.11.2-7            Embedded GNU C Library: Shared lib
ii  libedit2             2.11-20080614-2     BSD editline and history libraries
ii  libgssapi-krb5-2     1.8.3+dfsg-3        MIT Kerberos runtime libraries - k
ii  libssl0.9.8          0.9.8o-3            SSL shared libraries
ii  passwd               1:4.1.4.2+svn3283-2 change and administer password and
ii  zlib1g               1:1.2.3.4.dfsg-3    compression library - runtime

Versions of packages openssh-client recommends:
ii  openssh-blacklist             0.4.1      list of default blacklisted OpenSS
ii  openssh-blacklist-extra       0.4.1      list of non-default blacklisted Op
ii  xauth                         1:1.0.4-1  X authentication utility

Versions of packages openssh-client suggests:
pn  keychain                      <none>     (no description available)
pn  libpam-ssh                    <none>     (no description available)
pn  ssh-askpass                   <none>     (no description available)

-- no debconf information