Bug#569018: openssh-client: recreate mux control socket

[Colin Watson <cjwatson@debian.org>]

On Tue, Feb 09, 2010 at 02:45:41PM +0200, Andrew O. Shadoura wrote:
> This patch enables re-creation of the control socket for multiplexing. Without 
> it, if ssh dies, it leaves socket in place, and newly started ssh cannot bind 
> to it.

Thanks for your patch.  This has certainly long been an irritating
property of multiplexing.

It seems to me that this patch makes it a bit too easy to accidentally
trash an existing master just by setting ControlMaster to "yes", though.
Wouldn't it be better to do something like pinging the master to find
out if it's dead before recreating the socket, and disable multiplexing
as before if it's still alive?  That way there'd be no question about
whether it's appropriate to recreate the socket.  You could do the same
kind of thing as 'ssh -O check' does.

(Also, it would be best for this to go upstream to bugzilla.mindrot.org.
I can proxy for you if you like, but sometimes it's both better and
quicker for upstream to be able to discuss the patch directly with the
author rather than via an intermediary.)

Regards,

-- 
Colin Watson                                       [cjwatson@debian.org]