Bug#551010: openssh: New Feature: Add support for PKCS#11 authentication via new binary package
On Wed, Oct 14, 2009 at 06:08:50PM -0400, Joshua Kinard wrote:
> I did a really basic check against the DSC file and against a binary
> deb using Lintian, and only got some minor warnings back, all of which
> appear to belong to the original package anyways and are probably
> known. I think I have everything covered in this patch -- I'm not
> familiar with Debian package management, so I wasn't sure if it was
> appropriate to put a new entry in debian/changelog or even revbump the
> version string any. This patch essentially replaces
> openssh_5.1p1-8.diff.gz (I suppose it could be called
> openssh_5.1p1-9.diff.gz instead), and should contain all the changes I
> made to get this feature to work.
Oh, notwithstanding my previous comments, you should generally submit
patches as the change that would be needed to take (in this instance)
5.1p1-8 to 5.1p1-9, not as a complete new .diff.gz which is essentially
impossible to review by eye and may conflict with unreleased changes in
revision control that you don't know about.
Putting a new entry in debian/changelog is usually reasonable enough;
just make the distribution field on the first line be "UNRELEASED"
rather than "unstable".
Regards,
--
Colin Watson [cjwatson@debian.org]
Reply to: