Bug#481018: openssh-server: Missing $syslog dependency in init.d LSB header

[Petter Reinholdtsen <pere@hungry.com>]

Package:  openssh-server
Version:  1:4.6p1-1
Severity: important
Tags:     patch
User:     initscripts-ng-devel@lists.alioth.debian.org
Usertags: incorrect-dependency

I discovered this problem in a test installation of Debian Edu.  The
ssh boot script can end up starting before syslog when dependency
based boot sequencing is enabled.  It should depend on $syslog.  When
looking at the dependency header, I found several issues I recommend
fixing.  There were no shutdown dependencies, which will lead to the
wrong shutdown order.  There is no need to depend on both $local_fs
and $remote_fs, as the latter implies the former.  Also, $remote_fs
implies $network, so there is no need to depend on that directly.

Here is a proposed patch to solve both issues.

diff -ru openssh-4.7p1.orig/debian/openssh-server.init openssh-4.7p1/debian/openssh-server.init
--- openssh-4.7p1.orig/debian/openssh-server.init       2008-05-13 09:13:00.000000000 +0200
+++ openssh-4.7p1/debian/openssh-server.init    2008-05-13 09:14:04.000000000 +0200
@@ -2,8 +2,8 @@

 ### BEGIN INIT INFO
 # Provides:            sshd
-# Required-Start:      $network $local_fs $remote_fs
-# Required-Stop:
+# Required-Start:      $remote_fs $syslog
+# Required-Stop:       $remote_fs $syslog
 # Default-Start:       2 3 4 5
 # Default-Stop:                0 1 6
 # Short-Description:   OpenBSD Secure Shell server

Happy hacking,
--
Petter Reinholdtsen