Bug#387386: openssh-client: ssh-add(1) prints error message to stdout

[Daniel Brockman <daniel@brockman.se>]

Package: openssh-client
Version: 1:4.3p2-3
Severity: normal
Tags: patch

Problem: `ssh-add -L' outputs the error message ``The agent
has no identities.'' to standard output.

Steps to reproduce:

  $ ssh-agent sh
  $ ssh-add -L 2>/dev/null
  The agent has no identities.

This causes problems for ssh-copy-id.  In particular,

  $ ssh-agent sh
  $ ssh-copy-id walrus
  Password:

  Now try logging into the machine, with "ssh 'walrus'", and check in:
  
    .ssh/authorized_keys
  
  to make sure we haven't added extra keys that you weren't expecting.

  $ ssh walrus
  Password:

  walrus:~$ cat .ssh/authorized_keys
  The agent has no identities.

The fix is trivial:

--- /home/daniel/src/openssh-4.3p2/ssh-add.c~	2005-11-22 09:37:09.000000000 +0100
+++ /home/daniel/src/openssh-4.3p2/ssh-add.c	2006-09-14 03:24:07.000000000 +0200
@@ -237,7 +237,7 @@
 		}
 	}
 	if (!had_identities) {
-		printf("The agent has no identities.\n");
+		fprintf(stderr, "The agent has no identities.\n");
 		return -1;
 	}
 	return 0;

-- System Information:
Debian Release: testing/unstable
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.17-2-486
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages openssh-client depends on:
ii  adduser             3.97                 Add and remove users and groups
ii  debconf [debconf-2. 1.5.4                Debian configuration management sy
ii  dpkg                1.13.22              package maintenance system for Deb
ii  libc6               2.3.6.ds1-4          GNU C Library: Shared libraries
ii  libcomerr2          1.39-1               common error description library
ii  libedit2            2.9.cvs.20050518-2.2 BSD editline and history libraries
ii  libkrb53            1.4.4-1              MIT Kerberos runtime libraries
ii  libncurses5         5.5-3                Shared libraries for terminal hand
ii  libselinux1         1.30.27-3            SELinux shared libraries
ii  libssl0.9.8         0.9.8b-3             SSL shared libraries
ii  passwd              1:4.0.18.1-2         change and administer password and
ii  zlib1g              1:1.2.3-13           compression library - runtime

openssh-client recommends no packages.

-- no debconf information