Bug#359335: ssh/openssh-server dependency problems prevent installation--maybe local goof

[Ross Boylan <ross@biostat.ucsf.edu>]

On Mon, 2006-03-27 at 18:57 -0500, Justin Pryzby wrote:
> On Mon, Mar 27, 2006 at 03:12:59PM -0800, Ross Boylan wrote:
> > init.d/ssh includes these lines
> > 
> >   restart)
> > 	check_config
> >         echo -n "Restarting OpenBSD Secure Shell server: sshd"
> > 	start-stop-daemon --stop --quiet --oknodo --retry 30
> > --pidfile /var/run/sshd.pid
> > 
> > We made some changes to get a 2nd sshd running, and may have edited this
> > by mistake.  The argument to --pidfile should be /var/run/sshd/sshd.pid.
> > 
> > With that change, things seem to work.
> > 
> > So, if the original file is like that, I think it should be fixed.
> > 
> > If it's not, sorry about the noise.  OK to close.
> /var/run/sshd.pid is what the original conffile has, and my upgrade
> worked.  Can this be closed, or is there still a bug?

My init.d/ssh file has most commands using /var/run/ssh/sshd.pid for the
pid file, except that restart was using /var/run/sshd.pid.  I assumed
the local change had been to lines after restart, but maybe it was to
the others.
  start)
	check_for_no_start
	check_privsep_dir
        echo -n "Starting OpenBSD Secure Shell server: sshd"
	start-stop-daemon --start --quiet --pidfile /var/run/sshd/sshd.pid
--exec /usr/sbin/sshd -- $SSHD_OPTS
        echo "."
	;;
  stop)
        echo -n "Stopping OpenBSD Secure Shell server: sshd"
	start-stop-daemon --stop --quiet --oknodo
--pidfile /var/run/sshd/sshd.pid
        echo "."
	;;

  reload|force-reload)
	check_for_no_start
	check_config
        echo -n "Reloading OpenBSD Secure Shell server's configuration"
	start-stop-daemon --stop --signal 1 --quiet --oknodo
--pidfile /var/run/sshd/sshd.pid --exec /usr/sbin/sshd
	echo "."
	;;

  restart)
	check_config
        echo -n "Restarting OpenBSD Secure Shell server: sshd"
	start-stop-daemon --stop --quiet --oknodo --retry 30
--pidfile /var/run/sshd/sshd.pid
	check_for_no_start
	check_privsep_dir
	start-stop-daemon --start --quiet --pidfile /var/run/sshd/sshd.pid
--exec /usr/sbin/sshd -- $SSHD_OPTS

So, I'd say that if all the pid file paths are consistent in the
original, this is our locally introduced goof, and it's OK to close.

If they aren't, then maybe there's a real problem that happened to show
up more obviously because I had two sshd's running.