Bug#323627: ssh: wrong exit status

[Alejandro Forero Cuervo <bachue@bachue.com>]

Package: ssh
Version: 1:3.8.1p1-8.sarge.4
Severity: normal


The manual for ssh reads:

> ssh exits with the exit status of the remote command or with 255 if an
> error occurred.

However, ssh is wrongly exiting with 1 sometimes when an error that
prevents the connection from being established occurs (such as getting
ECONNREFUSED or ENETUNREACH):

$ ssh -p 4444 localhost ; echo $?
ssh: connect to host localhost port 24823: Connection refused
1

Another example (after ifdown eth1):

$ ssh bachue.com ; echo $?
ssh: connect to host bachue.com port 22: Network is unreachable
1

-- System Information:
Debian Release: 3.1
  APT prefers unstable
  APT policy: (500, 'unstable')
Architecture: i386 (i686)
Shell:  /bin/sh linked to /bin/bash
Kernel: Linux 2.6.11
Locale: LANG=C, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)

Versions of packages ssh depends on:
ii  adduser                     3.63         Add and remove users and groups
ii  debconf                     1.4.50       Debian configuration management sy
ii  dpkg                        1.10.28      Package maintenance system for Deb
ii  libc6                       2.3.2.ds1-22 GNU C Library: Shared libraries an
ii  libpam-modules              0.76-22      Pluggable Authentication Modules f
ii  libpam-runtime              0.76-22      Runtime support for the PAM librar
ii  libpam0g                    0.76-22      Pluggable Authentication Modules l
ii  libssl0.9.7                 0.9.7g-1     SSL shared libraries
ii  libwrap0                    7.6.dbs-8    Wietse Venema's TCP wrappers libra
ii  zlib1g                      1:1.2.2-4    compression library - runtime

-- debconf information excluded