[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#296487: ssh-askpass-gnome: Obscured ssh-askpass dialog



Package: ssh-askpass-gnome
Version: 1:3.8.1p1-8.sarge.4
Severity: wishlist
Tags: patch

Hi Matthew,

I add my keys to ssh-agent with ssh-add -c. If I'm in the process of
switching between windows when ssh invokes ssh-askpass obtain permission
to use my keyring, the ssh-askpass dialog might end up being placed
under some other window. Since it grabs the keyboard (and optionally the
mouse) it's difficult or impossible to switch focus back to the window;
although keypresses do go to it, I have to do it blindly, as it were.

Here's a one-line patch to make the ssh-askpass dialog box stay above
other windows (at least, for the GTK2 version. It doesn't look possible
with GTK1...?), which circumvents this occassionally annoying issue.

Cheers,
/Liyang

-- System Information:
Debian Release: 3.0
Architecture: i386
Kernel: Linux portal 2.4.24 #1 Mon Feb 9 22:57:26 GMT 2004 i686
Locale: LANG=en_GB.UTF-8, LC_CTYPE=en_GB.UTF-8

Versions of packages ssh-askpass-gnome depends on:
ii  libatk1.0-0          1.8.0-4             The ATK accessibility toolkit
ii  libc6                2.3.2.ds1-10        GNU C Library: Shared libraries an
ii  libglib2.0-0         2.6.1-2             The GLib library of C routines
ii  libgtk2.0-0          2.4.14-2            The GTK+ graphical user interface 
ii  libpango1.0-0        1.6.0-3             Layout and rendering of internatio
ii  ssh                  1:3.8.1p1-8.sarge.3 Secure rlogin/rsh/rcp replacement 
ii  xlibs                4.3.0-7             X Window System client libraries m

-- no debconf information

diff -ru openssh-3.8.1p1/contrib/gnome-ssh-askpass2.c openssh-3.8.1p1-above/contrib/gnome-ssh-askpass2.c
--- openssh-3.8.1p1/contrib/gnome-ssh-askpass2.c	2003-11-21 12:48:56.000000000 +0000
+++ openssh-3.8.1p1-above/contrib/gnome-ssh-askpass2.c	2005-02-22 18:22:26.000000000 +0000
@@ -111,6 +111,7 @@
 
 	gtk_window_set_title(GTK_WINDOW(dialog), "OpenSSH");
 	gtk_window_set_position (GTK_WINDOW(dialog), GTK_WIN_POS_CENTER);
+	gtk_window_set_keep_above(GTK_WINDOW(dialog), TRUE);
 	gtk_label_set_line_wrap(GTK_LABEL((GTK_MESSAGE_DIALOG(dialog))->label),
 				TRUE);
 

Reply to: