Bug#232201: marked as done (ssh: scp loses exit status for remote-to-remote copy)
Your message dated Sat, 1 May 2004 15:25:39 +0100
with message-id <20040501142539.GA5140@riva.ucam.org>
and subject line Bug#232201: FIX
has caused the attached Bug report to be marked as done.
This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
Bug report if necessary, and/or fix the problem forthwith.
(NB: If you are a system administrator and have no idea what I am
talking about this indicates a serious mail system misconfiguration
somewhere. Please contact me immediately.)
Debian bug tracking system administrator
(administrator, Debian Bugs database)
--------------------------------------
Received: (at submit) by bugs.debian.org; 11 Feb 2004 10:08:52 +0000
>From jarek@srv.pl Wed Feb 11 02:08:52 2004
Return-path: <jarek@srv.pl>
Received: from master.debian.org [146.82.138.7]
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1AqrIa-0002DR-00; Wed, 11 Feb 2004 02:08:52 -0800
Received: from cs105.neoplus.adsl.tpnet.pl ([192.168.0.181]) [80.54.215.105]
by master.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1AqrIW-0002uz-00; Wed, 11 Feb 2004 04:08:48 -0600
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
From: Jaroslaw Tabor <jarek@srv.pl>
To: Debian Bug Tracking System <submit@bugs.debian.org>
Subject: ssh: scp returns 0 if file cannot be copied.
X-Mailer: reportbug 2.43
Date: Wed, 11 Feb 2004 11:08:06 +0100
X-Debbugs-Cc: jarek@srv.pl
Message-Id: <E1AqrIW-0002uz-00@master.debian.org>
Delivered-To: submit@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_02_10
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-6.0 required=4.0 tests=HAS_PACKAGE,OUR_MTA_MSGID,
X_DEBBUGS_CC autolearn=no version=2.60-bugs.debian.org_2004_02_10
X-Spam-Level:
Package: ssh
Version: 1:3.6.1p2-11
Severity: normal
scp called to copy file between two remote hosts exits with return code
0 if connection to second host fails.
Example:
scp localhost:file remotehost:file;echo $?
ssh: connect to host remotehost port 22: No route to host
0
SSH is configured with RSA public key authentication (no password)
-- System Information:
Debian Release: testing/unstable
APT prefers unstable
APT policy: (500, 'unstable')
Architecture: i386 (i686)
Kernel: Linux 2.6.1
Locale: LANG=pl_PL, LC_CTYPE=pl_PL (ignored: LC_ALL set to pl_PL)
Versions of packages ssh depends on:
ii adduser 3.51 Add and remove users and groups
ii debconf 1.4.9 Debian configuration management sy
ii dpkg 1.10.18 Package maintenance system for Deb
ii libc6 2.3.2.ds1-11 GNU C Library: Shared libraries an
ii libpam-modules 0.76-15 Pluggable Authentication Modules f
ii libpam-runtime 0.76-15 Runtime support for the PAM librar
ii libpam0g 0.76-15 Pluggable Authentication Modules l
ii libssl0.9.7 0.9.7c-5 SSL shared libraries
ii libwrap0 7.6-ipv6.1-3 Wietse Venema's TCP wrappers libra
ii zlib1g 1:1.2.1-4 compression library - runtime
-- debconf information:
* ssh/privsep_tell:
ssh/insecure_rshd:
ssh/privsep_ask: true
ssh/ssh2_keys_merged:
* ssh/user_environment_tell:
* ssh/forward_warning:
ssh/insecure_telnetd:
ssh/new_config: true
* ssh/use_old_init_script: true
* ssh/protocol2_only: true
ssh/encrypted_host_key_but_no_keygen:
* ssh/run_sshd: true
* ssh/SUID_client: true
---------------------------------------
Received: (at 232201-done) by bugs.debian.org; 1 May 2004 14:25:42 +0000
>From cjwatson@flatline.org.uk Sat May 01 07:25:42 2004
Return-path: <cjwatson@flatline.org.uk>
Received: from chiark.greenend.org.uk [193.201.200.170] (mail)
by spohr.debian.org with esmtp (Exim 3.35 1 (Debian))
id 1BJvR0-0007Rk-00; Sat, 01 May 2004 07:25:42 -0700
Received: from [192.168.124.112] (helo=riva.lab.dotat.at)
by chiark.greenend.org.uk (Debian Exim 3.35 #1) with esmtp
for 232201-done@bugs.debian.org
id 1BJvQy-0002YC-00; Sat, 01 May 2004 15:25:40 +0100
Received: from cjwatson by riva.lab.dotat.at with local (Exim 3.35 #1 (Debian))
for 232201-done@bugs.debian.org
id 1BJvQx-0001M2-00; Sat, 01 May 2004 15:25:39 +0100
Date: Sat, 1 May 2004 15:25:39 +0100
From: Colin Watson <cjwatson@debian.org>
To: 232201-done@bugs.debian.org
Subject: Re: Bug#232201: FIX
Message-ID: <20040501142539.GA5140@riva.ucam.org>
References: <1076499433.4506.4.camel@jarek>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1076499433.4506.4.camel@jarek>
User-Agent: Mutt/1.3.28i
Delivered-To: 232201-done@bugs.debian.org
X-Spam-Checker-Version: SpamAssassin 2.60-bugs.debian.org_2004_03_25
(1.212-2003-09-23-exp) on spohr.debian.org
X-Spam-Status: No, hits=-5.0 required=4.0 tests=BAYES_00,HAS_BUG_NUMBER
autolearn=no version=2.60-bugs.debian.org_2004_03_25
X-Spam-Level:
X-CrossAssassin-Score: 1
On Wed, Feb 11, 2004 at 12:37:13PM +0100, JarosÅ?aw Tabor wrote:
> Below is fix for the bug. I will send it also to openssh.org. It looks
> that it also exists in latest openss-3.7.1.p2.
This was fixed in OpenSSH 3.8p1.
revision 1.119
date: 2003/09/22 11:14:55; author: dtucker; state: Exp; lines: +3 -2
- markus@cvs.openbsd.org 2003/09/19 17:40:20
[scp.c]
error handling for remote-remote copy; #638; report Harald Koenig;
ok millert, fgs, henning, deraadt
> openssh-3.6.1p2/scp.c:
>
> 360c360
> < int i, len;
> ---
> > int i, len, rc;
> 425c425,429
> < (void) system(bp);
> ---
> > rc = system(bp);
> > if (verbose_mode)
> > fprintf(stderr, "RC: %d\n", rc);
> > if( rc > 0 )
> > exit(1);
>
> I hope I did it in right way :)
You should usually generate diffs using 'diff -u'. Plain diff is very
hard to read, and the lack of context in the output means that the diffs
are often impossible to apply to versions of the file other than the
exact one you had.
Cheers,
--
Colin Watson [cjwatson@flatline.org.uk]
Reply to: