Re: Testing Firefox 62 on sparc64
On 08/17/2018 12:20 PM, Romain Dolbeau wrote:
> 2018-08-09 14:50 GMT+02:00 John Paul Adrian Glaubitz
> <glaubitz@physik.fu-berlin.de>:
>> Did you install the debug package so we can see where it actually
>> crashes in ProcessExecutableMemory.cpp?
>
> With 62.0~b16-1 on my t5120 (tunneled X11 - dunno if it changes the
> behavior), running with the dbgsym package under gdb:
>
> #####
> Thread 1 "firefox" received signal SIGBUS, Bus error.
> HashIIDPtrKey (key=0xffff80010a425aec <xpt::detail::sInterfaces+30352>)
> at /build/firefox-qTMIsZ/firefox-62.0~b16/js/xpconnect/src/XPCMaps.cpp:26
> 26 /build/firefox-qTMIsZ/firefox-62.0~b16/js/xpconnect/src/XPCMaps.cpp:
This is exactly this bug: https://bugzilla.mozilla.org/show_bug.cgi?id=1434726
The patch is trivial:
diff --git a/js/xpconnect/src/XPCMaps.cpp b/js/xpconnect/src/XPCMaps.cpp
index bb99b9f8c034..837d5d78970f 100644
--- a/js/xpconnect/src/XPCMaps.cpp
+++ b/js/xpconnect/src/XPCMaps.cpp
@@ -23,7 +23,7 @@ using namespace mozilla;
static PLDHashNumber
HashIIDPtrKey(const void* key)
{
- return HashGeneric(*((uintptr_t*)key));
+ return HashGeneric(((nsID*)key)->m0);
}
static bool
but not accepted upstream. We have to take a different approach using memcpy().
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz@debian.org
`. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Reply to: