Re: request to rebuild my package libcork (FTBFS on landau, but was built OK on andi)
Dear James,
Thanks for your patch!
And sorry for my late reply..
I'm trying to handle the SONAME first, since the transition freeze
will come soon.
(although I'll try to not get involved in transition. explaining below)
On Mon, Aug 29, 2016 at 10:23 PM, James Clarke <jrtc27@jrtc27.com> wrote:
>
> Whilst building the package, I couldn’t help but notice that libcork15 contains
> libcork.so.15, which is a symlink to libcork.so.16.0.1. This is clearly very
> very wrong (package name should be bumped up to libcork16, and the symlink
> should be called libcork.so.16). The cause of this is a crazy calculation in
> upstream’s cmake/FindCTargets.cmake, where on line 66 it does:
>
> math(EXPR __SOVERSION "${__VERSION_CURRENT} - ${__VERSION_AGE}”)
I created the patch, just works as you suggested.
So could you kindly help to review it?
- https://github.com/rogers0/libcork/commit/8d45ec
> This is then used to create the libcork.so.$__SOVERSION symlink, and given that
> __VERSION_CURRENT is 16 and __VERSION_AGE is 1, it calculates 16-1=15.
> __SOVERSION and __VERSION_CURRENT should be the same thing. Please request a
> transition, patch FindCTargets.cmake, bump the package name up to libcork16,
> upload the fixed version and file binNMUs. And, of course, get upstream
> patched.
Since there's no ABI change from libcork15 to libcork16, they should
be no problem to replace the old with the new.
So here's my solution:
- https://github.com/rogers0/libcork/commit/f222c5
Do you think it's a good idea to avoid transition?
I have tried to install the local built packages (including above two
commits) on my PC with other packages depending on libcork15, so I
confirm the installation is with no problem:
====
# dpkg -i libcork16_0.15.0+ds-7_amd64.deb libcork-dev_0.15.0+ds-7_amd64.deb
Selecting previously unselected package libcork16:amd64.
dpkg: considering removing libcork15:amd64 in favour of libcork16:amd64 ...
dpkg: yes, will remove libcork15:amd64 in favour of libcork16:amd64
(Reading database ... 277621 files and directories currently installed.)
Preparing to unpack libcork16_0.15.0+ds-7_amd64.deb ...
Unpacking libcork16:amd64 (0.15.0+ds-7) ...
Selecting previously unselected package libcork-dev:amd64.
Preparing to unpack libcork-dev_0.15.0+ds-7_amd64.deb ...
Unpacking libcork-dev:amd64 (0.15.0+ds-7) ...
Setting up libcork16:amd64 (0.15.0+ds-7) ...
Setting up libcork-dev:amd64 (0.15.0+ds-7) ...
Processing triggers for libc-bin (2.24-3) ...
====
I'll apply your patch after soname bumping up.
Thanks for your understanding!
Cheers,
--
Roger Shimizu, GMT +9 Tokyo
PGP/GPG: 4096R/6C6ACD6417B3ACB1
Reply to: