Re: [PATCH] silo: Add 64-bit support
On 11/24/2016 11:32 PM, James Clarke wrote:
> Part of the problem is not forcing 64-bit, but that the Makefile is inconsistent.
> The default CC is gcc without any flags, but ld is given -m elf64_sparc. If you
> are running with sparc32 as your default target, gcc will generate 32-bit files
> but ld expects 64-bit. If you really want to force 64-bit, you should also pass
> appropriate -m64/-64 flags to gcc/as. However, I think the sensible, least
> controversial solution is to just drop the -m elf64_sparc and let everything
> be the default. It was only changed to force 32-bit in c836dbda because 64-bit
> support wasn’t present.
Thank you! This is actually very constructive criticism which actually helps
improving the patch. I'll look into improving the Makefile.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - glaubitz@debian.org
`. `' Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913
Reply to: