Re: Pending sparc patches
Hello Jurij,
* Jurij Smakov <jurij@wooyd.org>, [2007-03-08 8:29 +0200]:
> Author : Emanuele Rocca <ema@debian.org>
> Date : Tue, 27 Feb 2007 00:23:28 +0100
> Message-ID : <20070226232328.GA6779@darkmoon.home>
> Status : included upstream
> Description : fixes unaligned access in ether1394_reset_priv()
>
> diff -aur a/drivers/ieee1394/eth1394.c b/drivers/ieee1394/eth1394.c
> --- a/drivers/ieee1394/eth1394.c 2006-09-20 06:42:06.000000000 +0300
> +++ b/drivers/ieee1394/eth1394.c 2007-03-08 08:01:43.000000000 +0200
> @@ -65,6 +65,7 @@
> #include <asm/uaccess.h>
> #include <asm/delay.h>
> #include <asm/semaphore.h>
> +#include <asm/unaligned.h>
> #include <net/arp.h>
>
> #include "csr1212.h"
> @@ -491,7 +492,7 @@
> int i;
> struct eth1394_priv *priv = netdev_priv(dev);
> struct hpsb_host *host = priv->host;
> - u64 guid = *((u64*)&(host->csr.rom->bus_info_data[3]));
> + u64 guid = get_unaligned(&(host->csr.rom->bus_info_data[3]));
> u16 maxpayload = 1 << (host->csr.max_rec + 1);
> int max_speed = IEEE1394_SPEED_MAX;
Actually upstream fixes other unaligned accesses in that very file.
Please apply the complete backport of upstream changes:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=412749;msg=5;filename=eth1394-unaligned.patch;att=1
Thanks!
ciao,
ema
Reply to: