[Git][snapshot-team/snapshot][master] 2 commits: Fix exception sorting packages for display in package_source_version

["Julien Cristau (@jcristau)" <gitlab@salsa.debian.org>]

Title: GitLab

Julien Cristau pushed to branch master at snapshot / snapshot

Commits:

• 0c03df15
  by Julien Cristau at 2022-09-27T19:18:35+02:00

  Fix exception sorting packages for display in package_source_version
  
  ERROR in app: Exception on /package/gcc-4.4/4.4.4-2linaro+armhf/ [GET]
  Traceback (most recent call last):
    File "/usr/lib/python3/dist-packages/flask/app.py", line 2447, in wsgi_app
      response = self.full_dispatch_request()
    File "/usr/lib/python3/dist-packages/flask/app.py", line 1952, in full_dispatch_request
      rv = self.handle_user_exception(e)
    File "/usr/lib/python3/dist-packages/flask/app.py", line 1821, in handle_user_exception
      reraise(exc_type, exc_value, tb)
    File "/usr/lib/python3/dist-packages/flask/_compat.py", line 39, in reraise
      raise value
    File "/usr/lib/python3/dist-packages/flask/app.py", line 1950, in full_dispatch_request
      rv = self.dispatch_request()
    File "/usr/lib/python3/dist-packages/flask/app.py", line 1936, in dispatch_request
      return self.view_functions[rule.endpoint](**req.view_args)
    File "/srv/snapshot.debian.org/code/web/app/snapshot/lib/cache.py", line 34, in wrapped
      rv = f(*args, **kwargs)
    File "/srv/snapshot.debian.org/code/web/app/snapshot/views/package.py", line 200, in package_source_version
      source_files.sort(key=lambda index: (fileinfo[index][0]['name'], index)
  TypeError: '<' not supported between instances of 'NoneType' and 'str'
  

• dafe59ff
  by Julien Cristau at 2022-09-27T20:06:01+00:00

  Merge branch 'sort-key' into 'master'
  
  Fix exception sorting packages for display in package_source_version
  
  See merge request snapshot-team/snapshot!3

1 changed file:

• web/app/snapshot/views/package.py

Changes:

web/app/snapshot/views/package.py

---

...	...	@@ -199,7 +199,7 @@ def package_source_version(source, version):
199	199
200	200	source_files.sort(key=lambda index: (fileinfo[index][0]['name'], index)
201	201	if len(fileinfo[index]) > 0
202		- else (None, index)) # reproducible file order
	202	+ else ('', index)) # reproducible file order
203	203
204	204	breadcrumbs = _build_crumbs(source, version)
205	205	title = f'{source} ({version})'

—
View it on GitLab.
You're receiving this email because of your account on salsa.debian.org. Manage all notifications · Help