[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFC: Invert ordering of issues in source package view: newest should be up



Hi Holger,

On Sat, Sep 13, 2014 at 01:35:06AM +0200, Holger Levsen wrote:
> Hi,
> 
> I think this is clearly a bugfix ;-) Please comment.
> 
> Both open and resolved issues will be inverse sorted, so that newest CVEs will 
> be on top of the list.
> 
> cheers,
> 	Holger
> 
> commit dd7b75472e00cea9759eb6554decf26c6fe8eb11
> Author: Holger Levsen <holger@layer-acht.org>
> Date:   Sat Sep 13 01:28:00 2014 +0200
> 
>     Invert ordering of issues in source package view: newest should be up.
> 
> diff --git a/lib/python/security_db.py b/lib/python/security_db.py
> index 8580d5b..b15924e 100644
> --- a/lib/python/security_db.py
> +++ b/lib/python/security_db.py
> @@ -1690,7 +1690,8 @@ class DB:
>              FROM bugs, package_notes as p
>              WHERE p.bug_name = bugs.name
>              AND ( bugs.name LIKE 'DSA-%' OR bugs.name LIKE 'DLA-%')
> -            AND p.package = ?""", (package,))
> +            AND p.package = ?
> +            ORDER BY bugs.release_date DESC""", (package,))

This changes the ordering in the 'Security announcements section,
ordering it by "release date" of the DSA/DLA, right? So for example
file will show with your patch:

DSA / DLA  Description
DLA-50-1   file - security update
DSA-3021-1 file - security update
DLA-27-1   file - security update
[...]

This looks like a good change to do, so "ack" at least from my side to
do so.

But above you mention to invert also the open and resolved CVEs by
descending order? Why do you like to do that?

Regards,
Salvatore


Reply to: