[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Bug#660190: security-tracker: add per-maintainer page (with half-baked patch)



On Sun, Mar 11, 2012 at 10:02 PM, Paul Wise wrote:
> On Fri, 2012-02-17 at 17:36 +0800, Paul Wise wrote:
>
>> The attached patch implements a first pass at a per-maintainer page of
>> security issues. It involves some database schema changes to it will
>> require a full reimport of all the data.
>
> Does anyone have some time to review my patch?

At a cursory glance, this seems more complicated that it needs to be.
You're creating an "id" for each source package, but that is redundant
since the package name itself is a unique id.

All you should need is a table with only sourcepkg names and
maintainer fields.  Then  when you process a view on (for example) a
maintainer page you can step through all sourcepkg names listed as
associated with that maintainer via that table.

Also, why is "c.execute("PRAGMA foreign_keys=ON")" necessary?

There is also a debugging print statement.

Best wishes,
Mike



Reply to: