On Sat, 2025-09-27 at 14:42 +0100, Richard Lewis wrote: > Me again, looking for a sponsor to upload chkrootkit 0.58b-6 , the changes are > pushed to git (https://salsa.debian.org/pkg-security-team/chkrootkit/). > > This fixes > - the FTBFS with gcc-15 > - (i hope), the FTBFS on hurd-* (as seen on https://buildd.debian.org/status/package.php?p=chkrootkit) > - some other minor tidying-up (mainly on the salsa pipeline) First of all: Thanks a lot for your work! Here come my comments: debian/changlog =============== There is no need to mention the single person who contributed changes if the same person is listed in the maintainer line (the last line of the changelog entry). Thus you can remove these two lines | | [ Richard Lewis ] I'd recommend to insert an empty line previous to the maintainer line. It's not required by the policy but contributes to readability. Maintaining the changelog using 'gbp dch' and 'dch' should help to keep the formatting this way. Please fix this. build on hurd-* =============== Unfortunately your fix is not enough, it now fails later in the process. In case you are interested in trying builds on The Hurd yourself, here is how I do it: * Set up a virtual machine (VM) based on the recent hurd-i386 image [1]. * Read the README [2] to learn how to run the VM. * Inside the running VM, make sure you have packages build-essential and debhelper installed. * Copy the source tree of your package into the VM. * Inside the running VM, - Install further build dependencies as per debian/control, - Change into the source tree, - Run "dpkg-buildpackage --no-sign --no-pre-clean --post-clean". Alternatively you can change Architecture in debian/control from "any" to "linux-any". This should suppress trying builds on hurd-*. You may even keep it as it is now. I leave it to your discretion how to proceed here, just let me know. Sven [1] https://cdimage.debian.org/cdimage/ports/latest/hurd-i386/debian-hurd.img.tar.xz [2] https://cdimage.debian.org/cdimage/ports/latest/hurd-i386/README -- GPG Fingerprint 3DF5 E8AA 43FC 9FDF D086 F195 ADF5 0EDA F8AD D585
Attachment:
signature.asc
Description: This is a digitally signed message part