Hi again, On Sat, 2024-01-06 at 10:58 +0100, Sven Geuer wrote: > Hi Peter, > > On Fri, 2024-01-05 at 20:59 +0000, Peter Wienemann wrote: > > Dear security tools packaging team, > > > > I pushed two commits to the ncrack repository [0] fixing two bugs: > > > > https://bugs.debian.org/1058286 > > https://bugs.debian.org/1048666 > > > > #1058286 is an RC bug. The suggested fix for #1048666 works but it > > is > > not particularly nice. If someone knows a smarter way how to > > address > > this issue, I am eager to learn about it. > > > > Instead of extending d/rules I propose to drop the offending files in > advance by a patch. This way there is not need to save and restore > them. Refer to [1] as an example. > > You can create such a patch easily via 'dquilt shell'. See [2] and > [3] if you are not familiar with it. > > [1] https://salsa.debian.org/debian-remote-team/tightvnc/-/blob/debian/master/debian/patches/remove-upstream-build-system.patch?ref_type=heads > [2] https://www.debian.org/doc/manuals/debmake-doc/ch03.en.html#quilt-setup > [3] https://manpages.debian.org/bookworm/quilt/quilt.1.en.html#shell > > An additional approach worth to explore is to patch upstream's Makefile.in files to do the clean job correctly. Some parts are already available as distclean targets. Cheers, Sven -- GPG Fingerprint 3DF5 E8AA 43FC 9FDF D086 F195 ADF5 0EDA F8AD D585
Attachment:
signature.asc
Description: This is a digitally signed message part