Richard Lewis <richard.lewis.debian@googlemail.com> writes: > Simon Josefsson <simon@josefsson.org> writes: > >> I was about to upload it, but noticed some minor nits that would be nice >> to fix -- I'm happy to upload anyway, but since you replied quickly >> maybe you could fix these before the upload: >> >> 1) Lintian debian-changelog-has-wrong-day-of-week 2024-08-26 was a Monday >> 2) Lintian unused-license-paragraph-in-dep5-copyright python > > Thanks -- fixed (i missed these, and now tell lintian to --fail-on > warnings locally) Uploaded now. Nice, so I learned the lintian and the SALSA_CI_AUTOPKGTEST_ALLOWED_EXIT_STATUS=0 settings, and will use those in other packages. >> 3) How about adding a wrap-and-sort CI check? The files aren't properly >> wrapped now. Add to debian/salsa-ci.yml: >> >> variables: >> SALSA_CI_ENABLE_WRAP_AND_SORT: 'true' >> SALSA_CI_WRAP_AND_SORT_ARGS: '-asbkt' >> >> and re-run wrap-and-sort, of course. Chose the args as you wish :) > > Also done, i was not aware of this command. > > I left out -a as it seems a bit un-neccessary for short fields, but if > there's a "team style" also happy to go with that. > > (I wish there was a way to have one-per-line if there is more than one > item, but keep a single line if there's only one thing). Yeah I haven't found a setting that produces "nice" results consistently. The final ',' in this line looks poor to me: +Uploaders: Marcos Fouces <marcos@debian.org>, Still, my preference is that any tool-enforced consistent style is better than non-verified unpredictable manual style. /Simon
Attachment:
signature.asc
Description: PGP signature