[Date Prev][Date Next] [Thread Prev][Thread Next] [Date Index] [Thread Index]

Re: RFS: HexWalk Request for sponsor



Hi Samuel,
Thank you for your time, actually the reviewers on mentors started only few days ago, it's the first time that I submit a package to debian, so pardon me if I didn't follow all the best practices.
I think I have catched your point, as long as the package is going on on mentors it is redundant to work on it on your side,
Thank you again,
Best Regards, 
Carmix

Il Sab 25 Mag 2024, 13:41 Samuel Henrique <samueloph@debian.org> ha scritto:
Hello Carmine,

> Anyway could you simply use the package that I have generated on mentors?

Now I understand it better, yes the one on mentors does build, and in your
sources you put the packaging under deb-packaging.

>From a technical standpoint, the package has a few lintian findings that have
to be fixed before the upload.

I recommend you set up a lintian hook in pdebuild, or use another solution
which integrates with lintian, or even call lintian manually over the
artifacts.

That's going to be useful even as upstream because lintian calls out upstream
issues too, for example in this case there's lack of hardening and a typo on
"Highlighting".

Now, on the maintenance side, I see that the package is not under the
pkg-security team (d/control), which is fine.

If the package were to be in the team, we would have to keep the packaging
separated from upstream (in a different git repo), because with the current way
it's not really possible to team-maintain the package. The packaging repo would
have all three branches we use (pristine-tar, upstream and debian/unstable),
the packaging would live in the debian/ folder, and the repo would live on
salsa.

Again, it's totally fine to not have the package under the team, if you want to
keep it all in a single git repo, and I see you already got some reviews on
mentors.

It's just that unfortunately I can't keep reviewing the package, I already have
too many things to do for the team-owned ones and I have to prioritize those.

That is pretty much a never-ending task, so I rarely have time to do
reviews outside of the team, my own packages, or the people I mentor directly.
Sorry.

Cheers,


--
Samuel Henrique <samueloph>

Reply to: